Remove Win32 / UWP / XB1 code from Starboard 17 #4002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaidokert
changed the title
kaidokert
force-pushed
the
sb17_clean_win
branch
3 times, most recently
from
08abc8e
to
e56ff96
Compare
niranjanyardi
force-pushed
the
sb17_clean_win
branch
from
e56ff96
to
cb3ff6a
Compare
niranjanyardi
approved these changes
Aug 16, 2024
|
For luxoft to build xb1 , they'll ahve to create commits on their branch which plugs into our high level GN config and then keep merging public github regularly.. correct ? |
andrewsavage1
approved these changes
Aug 16, 2024
Correct. However note - this is currently on our feature branch. And we need to remove MSVC support from our Starboard GN code in main, sometime soon. All |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b/360158667