Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documents to run Cobalt on Linux in evergreen mode #4108

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

jonastsai
Copy link
Contributor

android document is updated as well for generating XML test result

b/361540371
b/362655498

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.55%. Comparing base (eb3f507) to head (b7f5077).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4108      +/-   ##
==========================================
- Coverage   57.57%   57.55%   -0.03%     
==========================================
  Files        1746     1745       -1     
  Lines       86403    86403              
==========================================
- Hits        49747    49729      -18     
- Misses      36656    36674      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kaidokert kaidokert requested a review from oxve September 12, 2024 23:55
@oxve
Copy link
Contributor

oxve commented Sep 13, 2024

The lint job failed with the errors below. Do you have the pre-commit hooks set up locally? They would reformat the files for you automatically when you try to commit.

Fix End of Files.........................................................Failed
- hook id: end-of-file-fixer
- exit code: 1
- files were modified by this hook

Fixing cobalt/site/docs/development/setup-linux.md

Trim Trailing Whitespace.................................................Failed
- hook id: trailing-whitespace
- exit code: 1
- files were modified by this hook

Fixing cobalt/site/docs/development/setup-linux.md

@jonastsai
Copy link
Contributor Author

Thanks Oscar. I have pre-commit hook installed now. I will update the documents all together with the review comments.

Copy link
Contributor

@hlwarriner hlwarriner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving the docs!

cobalt/site/docs/development/setup-linux.md Outdated Show resolved Hide resolved
cobalt/site/docs/development/setup-linux.md Outdated Show resolved Hide resolved
cobalt/site/docs/development/setup-linux.md Outdated Show resolved Hide resolved
cobalt/site/docs/development/setup-linux.md Outdated Show resolved Hide resolved
cobalt/site/docs/development/setup-linux.md Show resolved Hide resolved
@jonastsai jonastsai force-pushed the b/361540371 branch 3 times, most recently from 1b0b3b1 to c098dfe Compare September 17, 2024 14:42
Copy link
Contributor

@oxve oxve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm from my pov

android document is updated as well for generating XML test result

b/361540371
b/362655498
@jonastsai jonastsai merged commit daf89fc into youtube:main Sep 19, 2024
228 of 231 checks passed
@oxve oxve added the cp-25.lts.1+ Cherry Pick to the 25.lts.1+ branch label Sep 19, 2024
cobalt-github-releaser-bot pushed a commit that referenced this pull request Sep 19, 2024
android document is updated as well for generating XML test result

b/361540371
b/362655498

(cherry picked from commit daf89fc)
oxve pushed a commit that referenced this pull request Sep 19, 2024
android document is updated as well for generating XML test result

b/361540371
b/362655498
oxve pushed a commit that referenced this pull request Sep 19, 2024
Refer to the original PRs:
* #3699
* #3855
* #4108

b/318730771
b/361540371
b/362655498

---------

Co-authored-by: Jonas Tsai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cp-25.lts.1+ Cherry Pick to the 25.lts.1+ branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants