Download test artifacts #4127
Open
Download test artifacts #4127
+80
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxve
force-pushed
the
download-test-results
branch
10 times, most recently
from
4dde62e
to
17d9ab3
Compare
oxve
force-pushed
the
download-test-results
branch
from
17d9ab3
to
37ef744
Compare
oxve
added a commit
that referenced
this pull request
Sep 19, 2024
Will allow #4127 to upload results for the platforms in question. b/288331664
Android and raspi emit junit xml files that MH pulls from the devices and uploads to GCS. Download those files and upload them as artifacts so the test report uploader will pick them up.
oxve
force-pushed
the
download-test-results
branch
from
ae8f354
to
2214554
Compare
kaidokert
reviewed
Sep 20, 2024
| run: | | ||
| set -uxe | ||
| i=0 | ||
| while [ $i -lt 6 ]; do |
There was a problem hiding this comment.
This is a bit opaque - what does 6 do here ? Just 6 retries ? A comment line would clarify
kaidokert
reviewed
Sep 20, 2024
| if: always() && env.TEST_TYPE == 'unit_test' | ||
| env: | ||
| COBALT_XMLS_FILENAME: cobalt_xmls.zip | ||
| COBALT_ERROR_LOG: webDriverTestLog.ERROR |
There was a problem hiding this comment.
Ideally we could leave that legacy name behind on the lab side and bring something cleaner here, e.g stdout.log and stderr.log, but i know this would prompt several layers of touches. So lets just accept it for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a build step that downloads the test artifacts from GCS.
b/288331664