refactor: remove #3008
Draft
refactor: remove #3008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for zarf-docs canceled.
|
Codecov ReportAttention: Patch coverage is
|
phillebaba
force-pushed
the
refactor/remove
branch
6 times, most recently
from
371bc06
to
78ce3dc
Compare
phillebaba
commented
Sep 20, 2024
| err := actions.Run(ctx, comp.Actions.OnRemove.Defaults, comp.Actions.OnRemove.OnFailure, nil) | ||
| if err != nil { | ||
| // TODO: I think we should return an error if failure action fails. Does this break existing use cases? | ||
| return fmt.Errorf("unable to run the failure action: %w", err) |
There was a problem hiding this comment.
I want to start returning an error if on failure action fails. Before it was a log message. Does this break existing use cases?
phillebaba
force-pushed
the
refactor/remove
branch
3 times, most recently
from
09b3d0b
to
d50a105
Compare
Signed-off-by: Philip Laine <[email protected]>
phillebaba
force-pushed
the
refactor/remove
branch
from
d50a105
to
03f12d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactors remove command.
Related Issue
Relates to #2969
Checklist before merging