Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dimension mapping improvements #1446

Merged
merged 3 commits into from
Jul 11, 2023
Merged

fix: dimension mapping improvements #1446

merged 3 commits into from
Jul 11, 2023

Conversation

tpluscode
Copy link
Collaborator

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Jul 10, 2023

🦋 Changeset detected

Latest commit: 9af233f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cube-creator/core-api Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov-commenter
Copy link

codecov-commenter commented Jul 10, 2023

Codecov Report

Merging #1446 (9af233f) into master (c7bc76b) will decrease coverage by 5.93%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1446      +/-   ##
==========================================
- Coverage   80.32%   74.39%   -5.93%     
==========================================
  Files         198      198              
  Lines       13645    13645              
  Branches      830      766      -64     
==========================================
- Hits        10960    10151     -809     
- Misses       2677     3486     +809     
  Partials        8        8              
Impacted Files Coverage Δ
...e/lib/domain/dimension-mapping/DimensionMapping.ts 96.77% <100.00%> (ø)
apis/core/lib/domain/queries/dimension-mappings.ts 100.00% <100.00%> (ø)

... and 18 files with indirect coverage changes

@tpluscode tpluscode merged commit 8385d22 into master Jul 11, 2023
17 checks passed
@tpluscode tpluscode deleted the mapping-munis branch July 11, 2023 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants