Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve validation: ensure consistent observedBy in ObservationConstraint #1508

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Rdataflow
Copy link

@Rdataflow Rdataflow commented Apr 26, 2024

  • pass contributor as argument
  • make cube:observedBy to be consistent in the ObservationConstraint
  • add test
  • drop injection

Copy link

changeset-bot bot commented Apr 26, 2024

⚠️ No Changeset found

Latest commit: f2a8da1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Rdataflow
Copy link
Author

@tpluscode would you mind starting the CI test ?

@Rdataflow
Copy link
Author

@tpluscode it seems the current workflow injects/overrides the observer but only in the observations...

How would it be possible to set the observer globally (observations, shape)?
would it i.e. make more sense to pass the observer argument in the transform step already (instead of injection) WDYT?

feel free to build upon theese crafted commits... it's at your disposition 👍

@Rdataflow Rdataflow marked this pull request as ready for review September 11, 2024 14:35
@Rdataflow Rdataflow changed the title test: observedBy in ObservationConstraint improve validation: ensure valid observedBy in ObservationConstraint Sep 13, 2024
@Rdataflow Rdataflow changed the title improve validation: ensure valid observedBy in ObservationConstraint improve validation: ensure consistent observedBy in ObservationConstraint Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants