Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: transform invalid dates #1523

Merged
merged 2 commits into from
Jun 17, 2024
Merged

fix: transform invalid dates #1523

merged 2 commits into from
Jun 17, 2024

Conversation

tpluscode
Copy link
Collaborator

No description provided.

Copy link

changeset-bot bot commented Jun 7, 2024

🦋 Changeset detected

Latest commit: 24c38a7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cube-creator/core-api Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.51%. Comparing base (cfdb26d) to head (24c38a7).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1523      +/-   ##
==========================================
+ Coverage   73.50%   73.51%   +0.01%     
==========================================
  Files         219      219              
  Lines       14880    14889       +9     
  Branches      849      855       +6     
==========================================
+ Hits        10937    10946       +9     
  Misses       3934     3934              
  Partials        9        9              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@giacomociti
Copy link
Contributor

giacomociti commented Jun 10, 2024

with the latest version of the csvw parser, invalid date values (like 'foo' or '500000') are correctly reported. Still, a value like '2000' is silently parsed successfully and transformed to '2000-01-01'^^xsd:date. Since '2000' would be invalid as an xsd:date but allowed by ISO 8601 I guess this is the desired behavior @tpluscode

@tpluscode
Copy link
Collaborator Author

I guess this is the desired behavior

Have you compared with the previous version?

@tpluscode tpluscode merged commit 8d5e92b into master Jun 17, 2024
18 of 19 checks passed
@tpluscode tpluscode deleted the invalid-date branch June 17, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants