Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dts files #33

Open
wants to merge 37 commits into
base: master
Choose a base branch
from
Open

Add dts files #33

wants to merge 37 commits into from

Conversation

juji
Copy link
Contributor

@juji juji commented Aug 8, 2024

Screenshot 2024-08-08 at 22 18 08

Adding dts files so typescript doesn't throw tantrum.

In the future, when updating, you can always create dts file using the provided script:

npm run types

@juji juji mentioned this pull request Aug 8, 2024
@zellwk
Copy link
Owner

zellwk commented Aug 12, 2024

Just want to let you know that I love this, @juji. I don't really know about typescript and this is super helpful. Can you let me know once you're done with the commits?

@juji
Copy link
Contributor Author

juji commented Aug 12, 2024

Thank you @zellwk this is a nice interface for fetch. I like it. Ready to be merged

@SteffQing
Copy link

Please merge this, lolz
Discovered ky but forgot the name, and in searching keywords, I discovered this lib
But I am hindered by typescript type checks
So, this is an important update @zellwk
Good work @juji Huge respects

@zellwk
Copy link
Owner

zellwk commented Aug 22, 2024

@juji thanks for the work. Give me a few days to sort out things on my plate and I’ll merge this.

@juji
Copy link
Contributor Author

juji commented Aug 23, 2024

Thanks again.. @zellwk

I forgot to remove options.body for GET, DELETE, also removed options.method from named function

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants