Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 对修复之前ie问题添加ie判断 #158

Closed
wants to merge 1 commit into from

Conversation

Lisuhan
Copy link
Contributor

@Lisuhan Lisuhan commented Apr 25, 2021

Description

之前在未播放状态时对播放器执行 update_time 操作,为了修复 ie 一个问题对未播放状态时间重置为0, 造成虽然给未播放状态播放器设置了开始时间,但一直从头播放,为修复这个问题,对之前这个 bug 降级判断 ie 浏览器才执行归零操作,以确保chrome等主流浏览器没有问题

Fixes # (issue)

How Has This Been Tested?

  • 完成自测

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@codecov-commenter
Copy link

codecov-commenter commented Apr 25, 2021

Codecov Report

Merging #158 (b6af89a) into master (b14a0a8) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #158      +/-   ##
==========================================
- Coverage   49.09%   49.06%   -0.03%     
==========================================
  Files         127      128       +1     
  Lines        1825     1826       +1     
==========================================
  Hits          896      896              
- Misses        929      930       +1     
Impacted Files Coverage Δ
packages/griffith/src/components/Player/Player.js 0.00% <0.00%> (ø)
packages/griffith/src/utils/isIE.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b14a0a8...b6af89a. Read the comment docs.

@@ -0,0 +1,5 @@
const isIE =
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个项目应该是期望能 SSR 工作的,改成 isIE = once(() => 可能好一些。

@iamaboot iamaboot requested review from aftdotleo and removed request for aftdotleo September 6, 2021 13:45
ambar added a commit to ambar/griffith that referenced this pull request Jan 29, 2022
ambar added a commit to ambar/griffith that referenced this pull request Jan 29, 2022
ambar added a commit that referenced this pull request Jan 29, 2022
@ambar
Copy link
Collaborator

ambar commented Jan 29, 2022

#249 中处理了

@ambar ambar closed this Jan 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants