add support for unix socket on pool connection #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi. Thanks for this PR. The only think is that in the main branch there should be no logging. All logging is in separate branch called logging ) Can you remove logger from this PR? |
|
You're right. On it.
…On Fri, 14 Apr 2023 at 12:04, zim32 ***@***.***> wrote:
Hi. Thanks for this PR. The only think is that in the main branch there
should be no logging. All logging is in separate branch called *logging* )
Can you remove logger from this request?
—
Reply to this email directly, view it on GitHub
<#47 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACG2OVT7IKYMSR4FTZMLO33XBEOJJANCNFSM6AAAAAAU5XHSNE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
what's the status on this PR? This would unblock folks like me who would like to use unix socket on GCP to connect to SQL instances |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.