-
-
Notifications
You must be signed in to change notification settings - Fork 828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v5.0.0 #890
base: master
Are you sure you want to change the base?
Conversation
About hooks and reactivity, especially in context of permissions, this github thread at expo has some interesting insight on the API design: expo/expo#31171 (comment) |
Hooks! |
I published a beta version, try it: Beta changelog
EDIT: Just published a second beta that switch back to async |
android/src/main/java/com/zoontek/rnpermissions/RNPermissionsModuleImpl.kt
Show resolved
Hide resolved
Juste published beta 2 to fix an issue with bob + the expo plugin (more infos callstack/react-native-builder-bob#598 (comment)) |
I don't quite understand what the flow would be to check and then request permissions if the check method returns a boolean. what if a user provides limited permissions but I want to force granted permissions. how would i know that permissions are limited and present user to click on a button to be redirected to Linking.openSettings(). Right now, i have this block of code. But if a user is presented this for the first time and they select limited permissions, then once request completes, they will be redirected to settings immediately.
|
As iOS 18 / Android 15 are around the corner, it's time to publish a new major version, as it will needs the latest Xcode version (v16) to be built. Let's perform some changes to improve this library in the same time.
I'm opening this to discuss about some points. I think it will be for the better, but I would love a community confirmation about them:
UNAVAILABLE
status, returnBLOCKED
instead (as it cannot be requested). That's one less thing to check, and it allows me to solves this issue. ✅Makecheck
andcheckMultiple
synchronouscheck
andcheckMultiple
return aboolean
(granted) (as Android will never returnblocked
on check, you have to call request to get the info anyway) ✅And, this is extra, but:
const [granted, request] = usePermission(…)
might be a thing, let's see how we can make it reactive.SCHEDULE_EXACT_ALARM
permission (closes feat(android): add schedule exact alarm permission #878)