Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for kms:Decrypt #62

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Allow for kms:Decrypt #62

wants to merge 1 commit into from

Conversation

shayfisher
Copy link

No IAM policy grants kms:Decrypt which is needed in order to decrypt the secret when KMS (CMK) is used.

if Secret Manager secrets are encrypted with KMS
@jmolnar-zscaler
Copy link
Collaborator

@shayfisher there are two ways to add customer managed key access. Either at the individual KMS policy with Instance Profile/Role or at the Instance Profile/Role as you are requesting. Generally, we wouldn't want to leave default resource access to * either.

There is an existing variable byo_kms_key_alias used for customer managed key for EBS encryption. Would you be utilizing the same CMK for EBS and Secrets Manager or expect these two to be different?

@shayfisher
Copy link
Author

Hi @jmolnar-zscaler
I expect them to be different.
Because I usually create resources with IaC I tend to split keys, each for each component.
So you are suggesting to add a new variable and have it as the permitted resource instead of “*”?

@shayfisher
Copy link
Author

@jmolnar-zscaler should I add a new variable representing an external kms key id and push an updated commit?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants