Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed TCP and UDP Port Drift on Application Segment Resources #481

Merged
merged 3 commits into from
Aug 29, 2024

Conversation

willguibr
Copy link
Member

@willguibr willguibr commented Aug 29, 2024

Provide a general summary of your changes in the title above. You should
remove this overview, any sections and any section descriptions you
don't need below before submitting. There isn't a strict requirement to
use this template if you can structure your description and still cover
these points.

Description

Describe your changes in detail through motivation and context. Why is
this change required? What problem does it solve? If it fixes an open
issue, link to the issue using GitHub's closing issues keywords1.

Has your change been tested?

Explain how the change has been tested and what you ran to confirm your
change affects other parts of the code. Automated tests are generally
expected and changes without tests should explain why they aren't
required.

Screenshots (if appropriate):

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented and stable APIs.

@codecov-commenter
Copy link

codecov-commenter commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 83.78378% with 12 lines in your changes missing coverage. Please review.

Project coverage is 74.89%. Comparing base (076b0c6) to head (f34a103).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
zpa/resource_zpa_application_segment.go 81.81% 5 Missing and 5 partials ⚠️
zpa/utils.go 86.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #481      +/-   ##
==========================================
+ Coverage   74.07%   74.89%   +0.81%     
==========================================
  Files          92       92              
  Lines       16857    16858       +1     
==========================================
+ Hits        12487    12625     +138     
+ Misses       3548     3389     -159     
- Partials      822      844      +22     
Files with missing lines Coverage Δ
zpa/resource_zpa_application_segment_inspection.go 65.25% <100.00%> (ø)
zpa/resource_zpa_application_segment_pra.go 58.15% <100.00%> (ø)
zpa/utils.go 71.27% <86.66%> (+1.49%) ⬆️
zpa/resource_zpa_application_segment.go 69.39% <81.81%> (+42.39%) ⬆️

... and 2 files with indirect coverage changes

@willguibr willguibr merged commit f4d9923 into master Aug 29, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Something isn't working
Projects
Status: 🚀 Shipped
Development

Successfully merging this pull request may close these issues.

One or more input fields tcpPortRanges are not valid after version v3.32.4
2 participants