Sourcery Starbot ⭐ refactored zxenonx/fastapi-project-template #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sourcery-ai-bot
commented
Aug 23, 2022
Comment on lines
-119
to
+120
| to_encode.update({"exp": expire}) | ||
| encoded_jwt = jwt.encode(to_encode, SECRET_KEY, algorithm=ALGORITHM) | ||
| return encoded_jwt | ||
| to_encode["exp"] = expire | ||
| return jwt.encode(to_encode, SECRET_KEY, algorithm=ALGORITHM) |
There was a problem hiding this comment.
Function create_access_token refactored with the following changes:
- Add single value to dictionary directly rather than using update() (
simplify-dictionary-update) - Inline variable that is immediately returned (
inline-immediately-returned-variable)
Comment on lines
-127
to
-132
| user = get_user(username) | ||
| if not user: | ||
| return False | ||
| if not verify_password(password, user.password): | ||
| if user := get_user(username): | ||
| return user if verify_password(password, user.password) else False | ||
| else: | ||
| return False | ||
| return user |
There was a problem hiding this comment.
Function authenticate_user refactored with the following changes:
- Swap if/else branches of if expression to remove negation (
swap-if-expression) - Use named expression to simplify assignment and conditional (
use-named-expression) - Lift code into else after jump in control flow [×2] (
reintroduce-else) - Swap if/else branches (
swap-if-else-branches) - Replace if statement with if expression (
assign-if-exp)
| contents = session.exec(select(Content)).all() | ||
| return contents | ||
| return session.exec(select(Content)).all() |
There was a problem hiding this comment.
Function list_contents refactored with the following changes:
- Inline variable that is immediately returned (
inline-immediately-returned-variable)
Comment on lines
-24
to
-32
| content = session.query(Content).where( | ||
| if content := session.query(Content).where( | ||
| or_( | ||
| Content.id == id_or_slug, | ||
| Content.slug == id_or_slug, | ||
| ) | ||
| ) | ||
| if not content: | ||
| ): | ||
| return content.first() | ||
| else: | ||
| raise HTTPException(status_code=404, detail="Content not found") | ||
| return content.first() |
There was a problem hiding this comment.
Function query_content refactored with the following changes:
- Use named expression to simplify assignment and conditional (
use-named-expression) - Lift code into else after jump in control flow (
reintroduce-else) - Swap if/else branches (
swap-if-else-branches)
| users = session.exec(select(User)).all() | ||
| return users | ||
| return session.exec(select(User)).all() |
There was a problem hiding this comment.
Function list_users refactored with the following changes:
- Inline variable that is immediately returned (
inline-immediately-returned-variable)
Comment on lines
-61
to
+60
| if not patch.password == patch.password_confirm: | ||
| if patch.password != patch.password_confirm: |
There was a problem hiding this comment.
Function update_user_password refactored with the following changes:
- Simplify logical expression using De Morgan identities (
de-morgan)
Comment on lines
-81
to
-90
| user = session.query(User).where( | ||
| if user := session.query(User).where( | ||
| or_( | ||
| User.id == user_id_or_username, | ||
| User.username == user_id_or_username, | ||
| ) | ||
| ) | ||
|
|
||
| if not user: | ||
| ): | ||
| return user.first() | ||
| else: | ||
| raise HTTPException(status_code=404, detail="User not found") | ||
| return user.first() |
There was a problem hiding this comment.
Function query_user refactored with the following changes:
- Use named expression to simplify assignment and conditional (
use-named-expression) - Lift code into else after jump in control flow (
reintroduce-else) - Swap if/else branches (
swap-if-else-branches)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for starring sourcery-ai/sourcery ✨ 🌟 ✨
Here's your pull request refactoring your most popular Python repo.
If you want Sourcery to refactor all your Python repos and incoming pull requests install our bot.
Review changes via command line
To manually merge these changes, make sure you're on the
mainbranch, then run: