app_rpt: Correct 5 digit node lookup from 4 digit node #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates app_rpt to address a problem with looking up a 5 or 6 digit node from a 4 digit node. The 4 digit node could not lookup 5 or 6 digit nodes when it did not use an external nodes file. This would happen if you are not using the node updater and depending on DNS only. The problem was associated with the internal 'longestnode' variable. We did not have an external file to determine the longest node number. In this case, the longest node was set to 4. A new define, 'MIN_NODE_LENGTH' has been added with a value of 6. The routines that determine the longest nodes will now MAX the value it determines with MIN_NODE_LENGTH.
This updates app_rpt to address a problem with looking up a 5 or 6 digit node from a 4 digit node. The 4 digit node could not lookup 5 or 6 digit nodes when it did not use an external nodes file. This would happen if you are not using the node updater and depending on DNS only. The problem was associated with the internal 'longestnode' variable. We did not have an external file to determine the longest node number. In this case, the longest node was set to 4. A new rpt.conf [general] item, maximum_node_length, has been added with a default value of 6. The routines that determine the longest nodes will now MAX the value it determines with maximum_node_length. The configurable item cannot be less than 4. By default, this configurable item will not be in rpt_conf. It can be used in the future if we need to support longer node numbers. Without this change, the problem can be remediated with existing installs, that don't use the node updater, by adding the following to rpt.conf [nodes]. 999999 = [email protected]:4569/999999,NONE
This updates app_rpt to address a problem with looking up a 5 or 6 digit node from a 4 digit node. The 4 digit node could not lookup 5 or 6 digit nodes when it did not use an external nodes file. This would happen if you are not using the node updater and depending on DNS only. The problem was associated with the internal 'longestnode' variable. We did not have an external file to determine the longest node number. In this case, the longest node was set to 4. A new rpt.conf [general] item, maximum_node_length, has been added with a default value of 6. The routines that determine the longest nodes will now MAX the value it determines with maximum_node_length. The configurable item cannot be less than 4 or more then 63. By default, this configurable item will not be in rpt_conf. It can be used in the future if we need to support longer node numbers. Without this change, the problem can be remediated with existing installs, that don't use the node updater, by adding the following to rpt.conf [nodes]. 999999 = [email protected]:4569/999999,NONE
This updates app_rpt to address a problem with looking up a 5 or 6 digit node from a 4 digit node. The 4 digit node could not lookup 5 or 6 digit nodes when it did not use an external nodes file. This would happen if you are not using the node updater and depending on DNS only. The problem was associated with the internal 'longestnode' variable. We did not have an external file to determine the longest node number. In this case, the longest node was set to 4. A new rpt.conf [general] item, max_dns_node_length, has been added with a default value of 6. The routines that determine the longest nodes will now MAX the value it determines with rpt_max_dns_node_length. The configurable item cannot be less than 4 or more then 63. By default, this configurable item will not be in rpt_conf. It can be used in the future if we need to support longer node numbers. Without this change, the problem can be remediated with existing installs, that don't use the node updater, by adding the following to rpt.conf [nodes]. 999999 = [email protected]:4569/999999,NONE
This updates app_rpt to address a problem with looking up a 5 or 6 digit node from a 4 digit node. The 4 digit node could not lookup 5 or 6 digit nodes when it did not use an external nodes file. This would happen if you are not using the node updater and depending on DNS only. The problem was associated with the internal 'longestnode' variable. We did not have an external file to determine the longest node number. In this case, the longest node was set to 4. A new rpt.conf [general] item, max_dns_node_length, has been added with a default value of 6. The routines that determine the longest nodes will now MAX the value it determines with rpt_max_dns_node_length. The configurable item cannot be less than 4 or more then 63. By default, this configurable item will not be in rpt_conf. It can be used in the future if we need to support longer node numbers. Additional level 4 debugging was added to the DNS lookup routine. Without this change, the problem can be remediated with existing installs, that don't use the node updater, by adding the following to rpt.conf [nodes]. 999999 = [email protected]:4569/999999,NONE
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates app_rpt to address a problem with looking up a 5 or 6 digit node from a 4 digit node. The 4 digit node could not lookup 5 or 6 digit nodes when it did not use an external nodes file. This would happen if you are not using the node updater and depending on DNS only.
The problem was associated with the internal 'longestnode' variable. We did not have an external file to determine the longest node number. In this case, the longest node was set to 4.
A new rpt.conf [general] item, max_dns_node_length, has been added with a default value of 6. The routines that determine the longest nodes will now MAX the value it determines with rpt_max_dns_node_length. The configurable item cannot be less than 4 or more then 63.
By default, this configurable item will not be in rpt_conf. It can be used in the future if we need to support longer node numbers.
Additional level 4 debugging was added to the DNS lookup routine.
Without this change, the problem can be remediated with existing installs, that don't use the node updater, by adding the following to rpt.conf [nodes].
999999 = [email protected]:4569/999999,NONE