Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Added a shell script to create the XCFramework needed when developing the iOS side. #1161

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Corvus400
Copy link
Contributor

Issue

  • None.

Overview (Required)

  • Since I forget the command every time when outputting XCFramework, I added a script that can output the minimum required XCFramework by executing a shell script.

@Corvus400 Corvus400 requested a review from a team as a code owner September 10, 2023 15:30
cd ../
./gradlew :app-io-shared:assembleSharedReleaseXCFramework
./gradlew :app-io-shared:assembleSharedDebugXCFramework
echo -e "\a"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I specified this because I want a sound to be played when the output is completed.

#!/bin/zsh

cd ../
./gradlew :app-io-shared:assembleSharedReleaseXCFramework
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Debug alone was not enough, so we also ran the assembleXCFramework in Release.

Copy link
Member

@takahirom takahirom Sep 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the iOS app currently doesn't use a debug framework so maybe we can remove it?
It is better to be able to use it to streamline the build though.

Copy link
Member

@takahirom takahirom Sep 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have strong opinion about this but there are a fastlane script to do this. Maybe iOS enginers are familiar with that way.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have any opinion on this? @RyuNen344

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@takahirom @RyuNen344 @ry-itto
Our goal is to facilitate iOS development, so of course if there is a better way, we would prefer it.🙌

@github-actions
Copy link

github-actions bot commented Sep 10, 2023

Test Results

215 tests   215 ✔️  10m 9s ⏱️
  11 suites      0 💤
  11 files        0

Results for commit 0f958cc.

♻️ This comment has been updated with latest results.

@github-actions github-actions bot temporarily deployed to deploygate-distribution September 10, 2023 16:06 Inactive
@github-actions github-actions bot temporarily deployed to deploygate-distribution September 11, 2023 07:58 Inactive
@github-actions github-actions bot temporarily deployed to deploygate-distribution September 16, 2023 10:21 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants