Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Added a shell script to create the XCFramework needed when developing the iOS side. #1161

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

✨ Added a shell script to create the XCFramework needed when developing the iOS side. #1161

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4dc71ab
:sparkles: Added a shell script to create the XCFramework needed when…
Corvus400 Sep 10, 2023
7da58b5
:wrench: Commented out commands that do not need to be used.
Corvus400 Sep 11, 2023
0f958cc
Merge branch 'main' into docs/add_assemble_xc_framework_script
Corvus400 Sep 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions scripts/assemble_xc_framework.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
#!/bin/zsh

cd ../
./gradlew :app-io-shared:assembleSharedReleaseXCFramework
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Debug alone was not enough, so we also ran the assembleXCFramework in Release.

Copy link
Member

@takahirom takahirom Sep 11, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the iOS app currently doesn't use a debug framework so maybe we can remove it?
It is better to be able to use it to streamline the build though.

Copy link
Member

@takahirom takahirom Sep 15, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have strong opinion about this but there are a fastlane script to do this. Maybe iOS enginers are familiar with that way.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have any opinion on this? @RyuNen344

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@takahirom @RyuNen344 @ry-itto
Our goal is to facilitate iOS development, so of course if there is a better way, we would prefer it.🙌

./gradlew :app-io-shared:assembleSharedDebugXCFramework
echo -e "\a"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I specified this because I want a sound to be played when the output is completed.

Loading