Selected clip length updates #7472
Conversation
Add a boolean to `removeNode` which indicates whether the clip length should be updated as well. Evaluate it in `removeNode`. Do not update the clip length when dragging a node in `AutomationClip::setDragValue`.
Do not update the clip length when dragging a node in `AutomationClip::setDragValue`. This is achieved by removing the call to `updateLength` from `AutomationClip::removeNode` and explicitly calling the update in all other places that call `removeNode` except in `setDragValue`. This commit therefore also improves the separation of concerns. Removing a node now only update the data structures. Updating the clip length is a completely different thing and rather a "policy" and therefore both calls should be done independently.
|
@michaelgregorius Please don't invite me to review just randomly. I am no expert at all about the topic (for Lv2, e.g., it would make sense), and I want to choose for myself which PRs and how many I review (note I am only a free-time developer). Also, I would rather recommend not to ask "at all" or "at lmms-developers" (or whatever the tag was to alert everyone), unless it it really relevant to all or requires feedback of everyone. |
|
@JohannesLorenz, sorry, I have invited you because you were proposed by the GitHub UI which stated that you would have already done some development/reviews for the changed code area. Unfortunately, I don't really have an overview of who is responsible for what. So oftentimes I search for developers that I already had some interactions with here. By the way, I am also not working professionally on LMMS. 😉 |
Do not update the clip length when dragging a node in
AutomationClip::setDragValue.This is achieved by removing the call to
updateLengthfromAutomationClip::removeNodeand explicitly calling the update in all other places that callremoveNodeexcept insetDragValue.This commit therefore also improves the separation of concerns. Removing a node now only update the data structures. Updating the clip length is a completely different thing and rather a "policy" and therefore both calls should be done independently.
Fixes #7466.