Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Selected clip length updates #7472

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Selected clip length updates #7472

wants to merge 2 commits into from

Commits on Aug 27, 2024

  1. Conditional clip length updates 

    Add a boolean to `removeNode` which indicates whether the clip length
should be updated as well. Evaluate it in `removeNode`.

Do not update the clip length when dragging a node in
`AutomationClip::setDragValue`.
    @michaelgregorius
    michaelgregorius committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    a321e90 View commit details
    Browse the repository at this point in the history

  2. Selected clip length updates 

    Do not update the clip length when dragging a node in
`AutomationClip::setDragValue`.

This is achieved by removing the call to `updateLength` from
`AutomationClip::removeNode` and explicitly calling the update in all
other places that call `removeNode` except in `setDragValue`.

This commit therefore also improves the separation of concerns.
Removing a node now only update the data structures. Updating the clip
length is a completely different thing and rather a "policy" and
therefore both calls should be done independently.
    @michaelgregorius
    michaelgregorius committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    44837db View commit details
    Browse the repository at this point in the history