Refactors and fix potential memory leak #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The purpose of this commit is to move parameters that otherwise would be assigned in the constructor to the initialization list. This could increase performance by avoiding a call to the default constructor.
The purpose of this commit is to remove lines that are never referenced again.
The changes proposed in this commit are to improve the performance of an iterator by pre-increment style.
This commit aims to prevent a potential memory leak given that memory could be referenced by the pointer. Freeing the pointer first, then assigning to new memory space should prevent this.
yunimoo
force-pushed
the
refactor-initialization-list
branch
from
3ad1779
to
c38c91d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Items in this PR address potential performance gains by: