Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactors and fix potential memory leak #58

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Commits on Jul 16, 2024

  1. Refactor constructors to use initialization list

    The purpose of this commit is to move parameters that otherwise would be
    assigned in the constructor to the initialization list. This could increase
    performance by avoiding a call to the default constructor.
    yunimoo committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    b5bd580 View commit details
    Browse the repository at this point in the history
  2. Refactor to remove unnecessary lines

    The purpose of this commit is to remove lines that are never referenced
    again.
    yunimoo committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    fc69c70 View commit details
    Browse the repository at this point in the history
  3. Refactor to use pre-increment on iterator

    The changes proposed in this commit are to improve the performance of an
    iterator by pre-increment style.
    yunimoo committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    4b39ba3 View commit details
    Browse the repository at this point in the history
  4. Prevent potential memory leak

    This commit aims to prevent a potential memory leak given that memory
    could be referenced by the pointer. Freeing the pointer first, then
    assigning to new memory space should prevent this.
    yunimoo committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    1c96da0 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    c38c91d View commit details
    Browse the repository at this point in the history