tectonic-unwrapped, tectonic: fix build #333143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryango
force-pushed
the
tectonic-rust-1.80-fix
branch
2 times, most recently
from
2e4659f
to
437a167
Compare
bryango
changed the title
SuperSandro2000
previously requested changes
Aug 8, 2024
|
Also it is easier if you target master if it still builds with the old rust. |
bryango
changed the title
bryango
force-pushed
the
tectonic-rust-1.80-fix
branch
from
4c3f840
to
95bd355
Compare
Add patch bumping the `time` crate, fix build with rust 1.80.
bryango
force-pushed
the
tectonic-rust-1.80-fix
branch
from
95bd355
to
b12a306
Compare
|
All fixed, |
doronbehar
dismissed
SuperSandro2000’s stale review
The cargoPatches request is resolved
doronbehar
approved these changes
Aug 9, 2024
wentasah
added a commit
to wentasah/nixpkgs
that referenced
this pull request
Aug 15, 2024
Hash mismatch was caused by NixOS#333143. The build error message contains: Validating consistency between /build/source/Cargo.lock and /build/texpresso-tonic-0.15.0-vendor.tar.gz/Cargo.lock 2372d2371 < "time", 2707c2706 < version = "0.3.36" --- > version = "0.3.34" ... ERROR: cargoHash or cargoSha256 is out of date Fixes NixOS#334648.
13 tasks
NickHu
pushed a commit
that referenced
this pull request
Aug 16, 2024
Hash mismatch was caused by #333143. The build error message contains: Validating consistency between /build/source/Cargo.lock and /build/texpresso-tonic-0.15.0-vendor.tar.gz/Cargo.lock 2372d2371 < "time", 2707c2706 < version = "0.3.36" --- > version = "0.3.34" ... ERROR: cargoHash or cargoSha256 is out of date Fixes #334648.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Add patch bumping the
timecrate, fix build with rust 1.80. See:timecrates tectonic-typesetting/tectonic#1209Upstream is slow on releases, so we need to patch it ourselves.
cargoPatchesis necessary for patchingCargo.lock; a naive list ofpatcheswon't do. This is documented in https://github.com/NixOS/nixpkgs/blob/master/doc/languages-frameworks/rust.section.md.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.