lspce: 1.0.0-unstable-2024-02-03 -> 1.1.0-unstable-2024-07-13

[AndersonTorres]

Description of changes

Fixing an Emacs package.

related: #278925

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[jian-lin]

Fixing cargoHash is enough to fix the build.

The old way of packaging makes more sense to me because lspce is an Emacs package which uses a dynamic module.

---

CI show another cargoHash error. Weird.

[AndersonTorres]

The old way of packaging makes more sense to me because lspce is an Emacs package which uses a dynamic module.

Hum, in a certain sense I agree. This package is not really useful outside Emacs.

However, the hardest work is made by Rust toolchain, while the Emacs part looks like a wrapper.
Indeed the modules can be built without any interference from Emacs ecosystem.
Further, technically the Emacs part depends on the Rust part.

Because of it I reworked the package this way: a Rust package with an Emacs companion package as passthru.

[jian-lin]

Indeed the modules can be built without any interference from Emacs ecosystem.
Further, technically the Emacs part depends on the Rust part.

Every Emacs package using a dynamic module depends on emacs-module.h of Emacs to build. lspce builds without explicit need of emacs-module.h because its core dependency, the emacs crate, vendors emacs-module.h.

[jian-lin]

The version change in #316332 causes the change of cargoHash. More info: #112763 (comment)

[AndersonTorres]

Apologies for the delay, I was dealing with some orphans and corpses.

I took a middle approach:

• The lspce-module has its own file;
• The elisp code calls this module.

outdated

[jian-lin]

lspce.el fails to compile.

My fix (with some minor improvements such as adding an update script) is available here: https://github.com/atorres1985-contrib/nixpkgs/compare/6837f904c5fad033ff35074903953c0de2a727bf...linj-fork:nixpkgs:tmp-pr/326981

If you are busy, I am willing to create a new PR because it seems that I cannot push to this specific PR for some reason.

[jian-lin]

Ideally, the bump and the refactor should be two separate PRs.

[jian-lin]

LGTM