Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cosmic-applets: unstable-2023-11-13 -> 1.0.0-alpha.1 #332252

Closed
wants to merge 1 commit into from

Conversation

a-kenji
Copy link
Contributor

@a-kenji a-kenji commented Aug 4, 2024

Description of changes

Part of: #259641
Obligatory: #327063

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@alyssais
Copy link
Member

alyssais commented Aug 5, 2024

Are there user-facing changes in this upgrade, since this adds a new Cargo.lock?

@alyssais
Copy link
Member

alyssais commented Aug 6, 2024

Okay, we definitely want this, because the version we have won't build with Rust 1.80.

I see this commit is tagged "epoch-1.0.0-alpha.1". Should we use that?

@a-kenji a-kenji changed the base branch from master to staging August 6, 2024 13:45
@a-kenji a-kenji changed the title cosmic-applets: unstable-2023-11-13 -> 0-unstable-2024-08-02 cosmic-applets: unstable-2023-11-13 -> 1.0.0-alpha.1 Aug 6, 2024
@ofborg ofborg bot requested a review from alyssais August 6, 2024 16:14
Copy link
Member

@alyssais alyssais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but why does this one need to go via staging rather than straight to master? Doesn't seem like it needs 1.80.0…

@K900 K900 closed this Aug 7, 2024
@NixOS NixOS locked as spam and limited conversation to collaborators Aug 7, 2024
@a-kenji a-kenji deleted the update/cosmic-applets branch August 7, 2024 15:15
@K900
Copy link
Contributor

K900 commented Aug 7, 2024

Mass ping, please resubmit.

@a-kenji a-kenji restored the update/cosmic-applets branch August 7, 2024 15:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants