-
-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sgdboop: init at 1.2.8 #341468
base: master
Are you sure you want to change the base?
sgdboop: init at 1.2.8 #341468
Conversation
1f79f8c
to
4614a2c
Compare
"cd" | ||
"cdgl" | ||
"cdcontextplus" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about other targets:
do_all: cd cdpdf cdgl cdim cdcontextplus cdlua5 cdluapdf5 cdluagl5 cdluacontextplus5 cdluaim5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about other targets:
do_all: cd cdpdf cdgl cdim cdcontextplus cdlua5 cdluapdf5 cdluagl5 cdluacontextplus5 cdluaim5
I figure that they weren't added originally because they weren't needed but I am not sure. Should I add those other targets?
Move to by-name Removed puffnfresh as a maintainer since the previous PR went stale and I am not sure if they still want to maintain this package. Rather be safe so they don't get mentioned if something with this does come up Rename to canvasdraw Co-authored-by: Saturn745 <[email protected]> Apply suggested changes
Move to by-name Remove puffnfresh as a maintainer and format Rename to imtoolkit Co-authored-by: Saturn745 <[email protected]> Apply suggested changes
Move to by-name Remove puffnfresh as a maintainer and format Update deps Co-authored-by: Saturn745 <[email protected]> Apply suggested changes
Move to by-name and update license Format Co-authored-by: Saturn745 <[email protected]> Apply suggested changes
4614a2c
to
2a4a651
Compare
Description of changes
This is a new PR based on @puffnfresh's original PR #269369, which went stale. I wasn't sure if I could do this or not, but I was told by a few people that I could so long as I kept Puffnfresh as a commiter, so I did. I also fixed trailing whitespace causing the editorconfig check to fail, updated the license for SGDBoop, and moved all of the packages to a
by-name
structure. One thing I was sure about was whether to keep Puffnfresh as a maintainer of these packages since his original PR went stale and nothing has been said from him. I did remove him from the maintainers of these, but I will add him back if he does want to maintain them.I apologize for any mistakes. I am still learning some things, and please let me know of any issues.
Closes: #269369, #220937
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.