Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vimPlugins.avante-nvim: init at 2024-09-14 #341927

Closed
wants to merge 2 commits into from
Closed

vimPlugins.avante-nvim: init at 2024-09-14 #341927

wants to merge 2 commits into from

Conversation

GaetanLepage
Copy link
Contributor

Description of changes

Adds https://github.com/yetone/avante.nvim

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@GaetanLepage GaetanLepage marked this pull request as draft September 14, 2024 22:45
@GaetanLepage
Copy link
Contributor Author

Result of nixpkgs-review pr 341927 run on x86_64-linux 1

2 packages built:
  • vimPlugins.avante-nvim
  • vimPluginsUpdater

@donovanglover
Copy link
Member

Duplicate of #339921

@donovanglover donovanglover marked this as a duplicate of #339921 Sep 14, 2024
@GaetanLepage
Copy link
Contributor Author

Duplicate of #339921

Thanks for linking this.
I have taken a slightly different approach.
@ttrei, feel free to copy/inspire from this if you feel like it.

@GaetanLepage GaetanLepage marked this pull request as ready for review September 14, 2024 23:44
PerchunPak
PerchunPak suggested changes Sep 15, 2024
View reviewed changes
pkgs/applications/editors/vim/plugins/overrides.nix
src = fetchFromGitHub {
owner = "yetone";
repo = "avante.nvim";
rev = "refs/tags/v${version}";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add an update script? Looks like this plugin is in rapid development, so I doubt you will remember to update it once in a while

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, done.
Well, I don't know if this will work and properly fetch the Cargo.lock...

pkgs/applications/editors/vim/plugins/overrides.nix

meta = {
homepage = "https://github.com/yetone/avante.nvim/";
changelog = "https://github.com/yetone/avante.nvim/releases/tag/v${version}";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be great to add meta.maintainers

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@GaetanLepage
Copy link
Contributor Author

The require check is failing:

Check whether the following module can be imported: avante
Error detected while processing pre-vimrc command line:
E518: Unknown option: /nix/store/vk7s8q1m0f0vl2ilcyv06vyna33qnzk0-vimplugin-lua5.1-plenary.nvim-scm-1-unstable-2024-05-20
E5108: Error executing lua ...1phk2md7-vimplugin-avante.nvim-0.0.2/lua/avante/path.lua:3: module 'plenary.path' not found:
        no field package.preload['plenary.path']
        no file './plenary/path.lua'
        no file '/nix/store/48vxxhagdr2llpibwswk88cwlzvp3909-luajit-2.1.1713773202/share/luajit-2.1/plenary/path.lua'
        no file '/usr/local/share/lua/5.1/plenary/path.lua'
        no file '/usr/local/share/lua/5.1/plenary/path/init.lua'
        no file '/nix/store/48vxxhagdr2llpibwswk88cwlzvp3909-luajit-2.1.1713773202/share/lua/5.1/plenary/path.lua'
        no file '/nix/store/48vxxhagdr2llpibwswk88cwlzvp3909-luajit-2.1.1713773202/share/lua/5.1/plenary/path/init.lua'
        no file './plenary/path.so'
        no file '/usr/local/lib/lua/5.1/plenary/path.so'
        no file '/nix/store/48vxxhagdr2llpibwswk88cwlzvp3909-luajit-2.1.1713773202/lib/lua/5.1/plenary/path.so'
        no file '/usr/local/lib/lua/5.1/loadall.so'
        no file './plenary.so'
        no file '/usr/local/lib/lua/5.1/plenary.so'
        no file '/nix/store/48vxxhagdr2llpibwswk88cwlzvp3909-luajit-2.1.1713773202/lib/lua/5.1/plenary.so'
        no file '/usr/local/lib/lua/5.1/loadall.so'
stack traceback:
        [C]: in function 'require'
        ...1phk2md7-vimplugin-avante.nvim-0.0.2/lua/avante/path.lua:3: in main chunk
        [C]: in function 'require'
        ...k2md7-vimplugin-avante.nvim-0.0.2/lua/avante/sidebar.lua:8: in main chunk
        [C]: in function 'require'
        ...1phk2md7-vimplugin-avante.nvim-0.0.2/lua/avante/init.lua:4: in main chunk
        [C]: in function 'require'
        [string ":lua"]:1: in main chunk
Error detected while processing /nix/store/mz3vd6ajja8y4vlmhfxgmx4k1phk2md7-vimplugin-avante.nvim-0.0.2/plugin/avante.lua:
E5113: Error while calling lua chunk: ...md7-vimplugin-avante.nvim-0.0.2/lua/avante/clipboard.lua:4: module 'plenary.path' not found:
        no field package.preload['plenary.path']
        no file './plenary/path.lua'
        no file '/nix/store/48vxxhagdr2llpibwswk88cwlzvp3909-luajit-2.1.1713773202/share/luajit-2.1/plenary/path.lua'
        no file '/usr/local/share/lua/5.1/plenary/path.lua'
        no file '/usr/local/share/lua/5.1/plenary/path/init.lua'
        no file '/nix/store/48vxxhagdr2llpibwswk88cwlzvp3909-luajit-2.1.1713773202/share/lua/5.1/plenary/path.lua'
        no file '/nix/store/48vxxhagdr2llpibwswk88cwlzvp3909-luajit-2.1.1713773202/share/lua/5.1/plenary/path/init.lua'
        no file './plenary/path.so'
        no file '/usr/local/lib/lua/5.1/plenary/path.so'
        no file '/nix/store/48vxxhagdr2llpibwswk88cwlzvp3909-luajit-2.1.1713773202/lib/lua/5.1/plenary/path.so'
        no file '/usr/local/lib/lua/5.1/loadall.so'
        no file './plenary.so'
        no file '/usr/local/lib/lua/5.1/plenary.so'
        no file '/nix/store/48vxxhagdr2llpibwswk88cwlzvp3909-luajit-2.1.1713773202/lib/lua/5.1/plenary.so'
        no file '/usr/local/lib/lua/5.1/loadall.so'
stack traceback:
        [C]: in function 'require'
        ...md7-vimplugin-avante.nvim-0.0.2/lua/avante/clipboard.lua:4: in main chunk
        [C]: in function 'require'
        ...4k1phk2md7-vimplugin-avante.nvim-0.0.2/plugin/avante.lua:13: in main chunk
Entering Ex mode.  Type "visual" to go to Normal mode.

@ttrei
Copy link
Contributor

ttrei commented Sep 15, 2024

@GaetanLepage, do you mind if i update #339921 with some of your changes, and then we try to merge that one?

@GaetanLepage
Copy link
Contributor Author

@GaetanLepage, do you mind if i update #339921 with some of your changes, and then we try to merge that one?

Sure, go for it !

@ttrei ttrei mentioned this pull request Sep 15, 2024
Merged
13 tasks
@ttrei
Copy link
Contributor

ttrei commented Sep 15, 2024

The require check is failing:

Check whether the following module can be imported: avante
...

This was a bug in the check hook, fixed in #339921

@GaetanLepage
Copy link
Contributor Author

Closing in favor of #339921

@GaetanLepage GaetanLepage deleted the avante branch September 15, 2024 22:14
@ttrei ttrei mentioned this pull request Sep 16, 2024
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@PerchunPak PerchunPak PerchunPak requested changes

@figsoda figsoda Awaiting requested review from figsoda figsoda is a code owner

@teto teto Awaiting requested review from teto

Assignees
No one assigned
Labels
6.topic: vim 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@GaetanLepage @donovanglover @ttrei @SuperSandro2000 @PerchunPak