Rename ArrayOps::ref_mut_from_core_array
#17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renames the method from the original `ref_from_mut_core_array`. I just tried to guess what we called this and couldn't, which is probably a sign it's a bad name. We use `ref_mut` elsewhere, e.g. `split_ref_mut`, and it nicely follows `deref_mut` from core as well. Though this is a breaking change, we don't seem to use this method elsewhere in the project yet, AFAICT.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renames the method from the original
ref_from_mut_core_array.I just tried to guess what we called this and couldn't, which is probably a sign it's a bad name.
We use
ref_mutelsewhere, e.g.split_ref_mut, and it nicely followsderef_mutfrom core as well.Though this is a breaking change, we don't seem to use this method elsewhere in the project yet, AFAICT.