Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename ArrayOps::ref_mut_from_core_array #17

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Rename ArrayOps::ref_mut_from_core_array #17

merged 1 commit into from
Jan 17, 2024

Commits on Jan 17, 2024

  1. Rename ArrayOps::ref_mut_from_core_array 

    Renames the method from the original `ref_from_mut_core_array`.

I just tried to guess what we called this and couldn't, which is
probably a sign it's a bad name.

We use `ref_mut` elsewhere, e.g. `split_ref_mut`, and it nicely follows
`deref_mut` from core as well.

Though this is a breaking change, we don't seem to use this method
elsewhere in the project yet, AFAICT.
    @tarcieri
    tarcieri committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    fa6d319 View commit details
    Browse the repository at this point in the history