[CELEBORN-1490][CIP-6] Impl worker write process for Flink Hybrid Shuffle #2741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reswqa
force-pushed
the
cip6-6-pr
branch
2 times, most recently
from
081b5fd
to
6b0bf5e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2741 +/- ##
==========================================
+ Coverage 33.11% 33.12% +0.01%
==========================================
Files 314 314
Lines 18373 18435 +62
Branches 1683 1691 +8
==========================================
+ Hits 6082 6104 +22
- Misses 11951 11989 +38
- Partials 340 342 +2 ☔ View full report in Codecov by Sentry. |
SteNicholas
reviewed
Sep 20, 2024
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/WorkerSource.scala
Show resolved
Hide resolved
SteNicholas
reviewed
Sep 20, 2024
worker/src/main/java/org/apache/celeborn/service/deploy/worker/storage/PartitionDataWriter.java
Outdated
Show resolved
Hide resolved
SteNicholas
reviewed
Sep 20, 2024
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/PushDataHandler.scala
Outdated
Show resolved
Hide resolved
SteNicholas
reviewed
Sep 20, 2024
...org/apache/celeborn/service/deploy/worker/storage/segment/SegmentMapPartitionFileWriter.java
Outdated
Show resolved
Hide resolved
SteNicholas
reviewed
Sep 20, 2024
.../src/main/java/org/apache/celeborn/service/deploy/worker/storage/MapPartitionDataWriter.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Xu Huang <[email protected]>
SteNicholas
reviewed
Sep 23, 2024
...org/apache/celeborn/service/deploy/worker/storage/segment/SegmentMapPartitionFileWriter.java
Outdated
Show resolved
Hide resolved
SteNicholas
reviewed
Sep 23, 2024
...org/apache/celeborn/service/deploy/worker/storage/segment/SegmentMapPartitionFileWriter.java
Outdated
Show resolved
Hide resolved
SteNicholas
reviewed
Sep 23, 2024
...org/apache/celeborn/service/deploy/worker/storage/segment/SegmentMapPartitionFileWriter.java
Show resolved
Hide resolved
|
@reswqa, could you provide the grafana metric dashboard renderings to help confirm whether the |
|
SteNicholas
reviewed
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Impl worker write process for Flink Hybrid Shuffle.
Why are the changes needed?
We supports tiered producer write data from flink to worker. In this PR, we enable the worker to write this kind of data to storage.
Does this PR introduce any user-facing change?
no
How was this patch tested?
no need.