fix missing virtual dtor on observable_reader_node #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes an issue where the observable_reader_node, which serve as a base class for reader_node, didn't have a virtual dtor. This was made easier to miss in virtue of observable_reader_node not having any virtual method. By having observable_reader_node derive from reader_node_base, we effectively fix the issue and by removing multiple inheritance. observable_reader_node now inherits its virtual dtor from reader_node_base.
|
Much better, yes, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes an issue where the observable_reader_node, which serve as a base class for reader_node, didn't have a virtual dtor.
This was made easier to miss in virtue of observable_reader_node not having any virtual method.
By having observable_reader_node derive from reader_node_base, we effectively fix the issue and by removing multiple inheritance. observable_reader_node now inherits its virtual dtor from reader_node_base.