Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix missing virtual dtor on observable_reader_node #211

Merged
merged 1 commit into from
Sep 18, 2024
Merged

fix missing virtual dtor on observable_reader_node #211

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions lager/detail/nodes.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ struct notifying_guard_t
* Interface for nodes capable of notifying observers.
*/
template <typename T>
class observable_reader_node
class observable_reader_node : public reader_node_base
{
public:
using value_type = T;
Expand Down Expand Up @@ -186,9 +186,7 @@ class observable_reader_node
* functionality for setting values and propagating them to children.
*/
template <typename T>
class reader_node
: public reader_node_base
, public observable_reader_node<T>
class reader_node : public observable_reader_node<T>
{
public:
using value_type = typename observable_reader_node<T>::value_type;
Expand Down
Loading