Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CTEST_PARALLEL_LEVEL #248

Merged
merged 5 commits into from
Sep 1, 2023
Merged

Use CTEST_PARALLEL_LEVEL #248

merged 5 commits into from
Sep 1, 2023

Conversation

TingDaoK
Copy link
Contributor

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@@ -246,7 +246,7 @@ def run(self, env):
return

ctest = toolchain.ctest_binary()
sh.exec(*toolchain.shell_env, ctest,
sh.exec(*toolchain.shell_env, ctest, "--parallel", str(os.cpu_count()),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? If this is affecting all repos then that's very concerning.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the tests are slow. Hmmm, do we have tests that cannot run in parallel? If so, I guess I'll just change s3 to run in parallel instead

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I worry about crt-cpp where we have mqtt tests that used unique client ids but share topics and cross-talk between them

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally all tests would be truly independent and mutually exclusive, but I don't think we're there yet.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I'll just enable it only for aws-c-s3 then.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still needs to update builder for the script to import environment variables

@TingDaoK
Copy link
Contributor Author

move to just s3

@TingDaoK TingDaoK closed this Aug 31, 2023
@TingDaoK TingDaoK reopened this Aug 31, 2023
@graebm graebm changed the title Run test in parallel by default Use CTEST_PARALLEL_LEVEL Sep 1, 2023
@TingDaoK TingDaoK merged commit 5cb04fe into main Sep 1, 2023
1 check passed
@TingDaoK TingDaoK deleted the run-test-in-parallel branch September 1, 2023 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants