Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use CTEST_PARALLEL_LEVEL #248

Merged
merged 5 commits into from
Sep 1, 2023
Merged

Use CTEST_PARALLEL_LEVEL #248

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
587c03f
run tests in parallel
TingDaoK Aug 31, 2023
1103b8f
make it as a string
TingDaoK Aug 31, 2023
a66701b
use the envrionment variables instead
TingDaoK Aug 31, 2023
34c2a84
use another way so that we can control it per repo
TingDaoK Aug 31, 2023
3589ca9
local test that should not commit
TingDaoK Aug 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion builder/actions/cmake.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,7 @@ def run(self, env):
return

ctest = toolchain.ctest_binary()
sh.exec(*toolchain.shell_env, ctest,
sh.exec(*toolchain.shell_env, ctest, "--parallel", str(os.cpu_count()),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? If this is affecting all repos then that's very concerning.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the tests are slow. Hmmm, do we have tests that cannot run in parallel? If so, I guess I'll just change s3 to run in parallel instead

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I worry about crt-cpp where we have mqtt tests that used unique client ids but share topics and cross-talk between them

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally all tests would be truly independent and mutually exclusive, but I don't think we're there yet.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I'll just enable it only for aws-c-s3 then.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still needs to update builder for the script to import environment variables

"--output-on-failure", working_dir=project_build_dir, check=True)
# Try to generate the coverage report. Will be ignored by ctest if no coverage data available.
sh.exec(*toolchain.shell_env, ctest,
Expand Down
1 change: 1 addition & 0 deletions test/aws-c-auth-staging
Open in desktop
Submodule aws-c-auth-staging added at 840047
Loading