Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump @vercel/ncc -> 0.38.1 and @actions/core -> 1.10.1 #268

Merged
merged 1 commit into from
Jan 20, 2024

Conversation

graebm
Copy link
Contributor

@graebm graebm commented Jan 19, 2024

Issue:
Dependabot wants to bump these npm dependencies. See:
#252
#253
#258
#259

But Github actions are weird and you need to run npm install and commit the artifacts after an npm update. So here's my own manual PR.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@bretambrose
Copy link
Contributor

Can we configure this to not get minor/patch PRs that aren't about security issues? This is kind of silly.

@graebm
Copy link
Contributor Author

graebm commented Jan 19, 2024

I don't see an option like that: https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file

I think it's supposed to be a painless thing where you just merge the PRs it puts up. These ones are weird thought because you're supposed to commit the build artifacts for Github Actions, and dependabot only does npm update it doesn't do npm install

@graebm graebm enabled auto-merge (squash) January 19, 2024 23:46
@graebm graebm disabled auto-merge January 19, 2024 23:46
@graebm graebm enabled auto-merge (squash) January 19, 2024 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants