Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(atomic): put noProducts action in search-box page object instead of base-page-object #4436

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

test(atomic): put noProducts action in search-box page object instead of base-page-object #4436

wants to merge 1 commit into from
+25 −25

Conversation

alexprudhomme
Copy link
Contributor

@alexprudhomme alexprudhomme requested a review from a team as a code owner September 18, 2024 22:07
@github-actions GitHub Actions
Copy link

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 239.2 239.2 0
commerce 337.8 337.8 0
search 407.2 407.2 0
insight 392.1 392.1 0
recommendation 250 250 0
ssr 401.3 401.3 0
ssr-commerce 350 350 0

SSR Progress

Use case SSR (#) CSR (#) Progress (%)
search 39 44 89
recommendation 0 4 0
case-assist 0 6 0
insight 0 27 0
commerce 0 15 0
Detailed logs search : buildInteractiveResult
search : buildInteractiveInstantResult
search : buildInteractiveRecentResult
search : buildInteractiveCitation
search : buildGeneratedAnswer
recommendation : missing SSR support
case-assist : missing SSR support
insight : missing SSR support
commerce : missing SSR support

@alexprudhomme alexprudhomme requested review from a team as code owners September 19, 2024 12:59
@alexprudhomme alexprudhomme requested review from erocheleau, SimonMilord and mmitiche and removed request for a team, erocheleau, SimonMilord and mmitiche September 19, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olamothe olamothe Awaiting requested review from olamothe olamothe is a code owner automatically assigned from coveo/search

@fpbrault fpbrault Awaiting requested review from fpbrault fpbrault is a code owner automatically assigned from coveo/search

@y-lakhdar y-lakhdar Awaiting requested review from y-lakhdar y-lakhdar is a code owner automatically assigned from coveo/search

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@alexprudhomme