Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bake: print warnings on progress #2534

Merged
merged 1 commit into from
Jul 1, 2024
Merged

Conversation

tonistiigi
Copy link
Member

Add progress warnings to the output for bake commands same way as they show up in build.

 1 warning found (use --debug to expand):
 - UndefinedVar: Usage of undefined variable '$PAHT' (did you mean $PATH?) (line 2)
 1 warning found:
 - UndefinedVar: Usage of undefined variable '$PAHT' (did you mean $PATH?) (line 2)
Variables should be defined before their use
More info: https://docs.docker.com/go/dockerfile/rule/undefined-var/
Dockerfile:2
--------------------
   1 |     FROM alpine
   2 | >>> ENV PATH=$PAHT:/foo
   3 |     RUN env && stop
   4 |
--------------------

--

There is a bit of an issue with this atm that when two targets invoked by bake use the same Dockerfile they are likely to generate the same warnings. Some deduplication would be needed.

@tonistiigi
Copy link
Member Author

@tonistiigi tonistiigi added this to the v0.16.0 milestone Jun 25, 2024
@tonistiigi tonistiigi marked this pull request as ready for review June 28, 2024 00:33
@tonistiigi
Copy link
Member Author

Issue with duplication was fixed in #2551

@crazy-max crazy-max merged commit 17878d6 into docker:master Jul 1, 2024
103 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants