-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove vue [do not merge] #534
Merged
Merged
Commits on Nov 2, 2023
-
It shouldn't be neccessary as instance. It should be available from outside
Configuration menu - View commit details
-
Copy full SHA for c4c0feb - Browse repository at this point
Copy the full SHA c4c0febView commit details
Commits on Dec 1, 2023
-
build: update vue(x) dependencies
- vuex and vue/compat are added to peerDependencies, they are not needed as regular dependencies - vue and vue-template-compiler (the latter needed for vue 2, but not vue 3) could be removed as dependencies - to be able to run the library in a vue 3 project, vuex is required in ^v4
Configuration menu - View commit details
-
Copy full SHA for e583f02 - Browse repository at this point
Copy the full SHA e583f02View commit details -
to be able to remove vuex as a direct dependency, we need to remove its usages in the library
Configuration menu - View commit details
-
Copy full SHA for 4d951ef - Browse repository at this point
Copy the full SHA 4d951efView commit details -
Configuration menu - View commit details
-
Copy full SHA for e3baff9 - Browse repository at this point
Copy the full SHA e3baff9View commit details -
to be able to remove vue as a dependency, we need to remove all its usages
Configuration menu - View commit details
-
Copy full SHA for bf5d684 - Browse repository at this point
Copy the full SHA bf5d684View commit details
Commits on Dec 5, 2023
-
build: add missing dev dependencies
these are needed for running the tests
Configuration menu - View commit details
-
Copy full SHA for 76bdfae - Browse repository at this point
Copy the full SHA 76bdfaeView commit details -
- since state.items is an object, using `findIndex` on it throws an error - instead, we can just use `delete` to delete the item
Configuration menu - View commit details
-
Copy full SHA for 717e4e0 - Browse repository at this point
Copy the full SHA 717e4e0View commit details
Commits on Dec 6, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 075d5f2 - Browse repository at this point
Copy the full SHA 075d5f2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 20f74c3 - Browse repository at this point
Copy the full SHA 20f74c3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7d10fbc - Browse repository at this point
Copy the full SHA 7d10fbcView commit details -
Configuration menu - View commit details
-
Copy full SHA for f578804 - Browse repository at this point
Copy the full SHA f578804View commit details -
Configuration menu - View commit details
-
Copy full SHA for 613270b - Browse repository at this point
Copy the full SHA 613270bView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.