refactor: remove vue [do not merge] #534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It shouldn't be neccessary as instance. It should be available from outside
- vuex and vue/compat are added to peerDependencies, they are not needed as regular dependencies - vue and vue-template-compiler (the latter needed for vue 2, but not vue 3) could be removed as dependencies - to be able to run the library in a vue 3 project, vuex is required in ^v4
hwiem
added a commit
to demos-europe/demosplan-core
that referenced
this pull request
Dec 1, 2023
- to work with vue 3, vuex needs to be updated to v4 - new Store() is now createStore() - vue/compat and vue/compiler-sfc need to be updated to make things work - vue-template-compiler is only needed in vue 2, so it can be removed - dependencies need to be updated in demosplan-ui and vuex-json-api, too: - demos-europe/demosplan-ui#658 - eFrane/vuex-json-api#534
This was referenced Dec 1, 2023
to be able to remove vuex as a direct dependency, we need to remove its usages in the library
to be able to remove vue as a dependency, we need to remove all its usages
these are needed for running the tests
- since state.items is an object, using `findIndex` on it throws an error - instead, we can just use `delete` to delete the item
salisdemos
requested changes
Dec 6, 2023
salisdemos
approved these changes
Dec 6, 2023
hwiem
added a commit
to demos-europe/demosplan-core
that referenced
this pull request
Dec 6, 2023
* build(refs T19759): update vuex to v4 - to work with vue 3, vuex needs to be updated to v4 - new Store() is now createStore() - vue/compat and vue/compiler-sfc need to be updated to make things work - vue-template-compiler is only needed in vue 2, so it can be removed - dependencies need to be updated in demosplan-ui and vuex-json-api, too: - demos-europe/demosplan-ui#658 - eFrane/vuex-json-api#534 * docs(refs T19759): remove redundant documentation comments * refactor(refs T19759): declare emitted events in vue 3, events emitted from a component need to be declared via the 'emits' option * refactor(refs T19759): define async components in vue 3, dynamic imports need to be wrapped in a `defineAsyncComponent()` * build(refs T19759): disable devtools in prod mode Co-authored-by: salisdemos <[email protected]> AB#9149 --------- Co-authored-by: Florian Salis <[email protected]> Co-authored-by: salisdemos <[email protected]>
14 tasks
eFrane
approved these changes
Dec 25, 2023
There was a problem hiding this comment.
Thank you for this massive piece of work!
I looked it through and besides bringing Vue 3 compat, this also makes the code so much more vanilla, which can only be a good thing in the long run.
The remaining question for me is, how do we merge this?
My proposal would be, to actually just throw it into main with a huge breaking disclaimer in the Changelog. There is enough of those already due to the whole fetch-refactoring from a while ago.
Versioning wise, we should probably go to 0.1.x with all of these changes. This would leave the 0.0.x branch open for any required fixes of this package in current production setups.
@hwiem @salisdemos wdyt?
|
I would agree with you and prefer a 0.1.x as well |
|
Sounds good for me. Totally agree. |
eFrane
added a commit
that referenced
this pull request
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow using this library in vue 3 projects:
vuea peer dependency (>= 3) (it remains a dev dependency too, as it is used in the tests)vuexa peer + dev dependency (>= 4, internal usages are removed, except for in tests)vue-template-compiler(only needed for vue 2)jestand related dependencies to work with vue 3Tasks