-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to filter chain by passing the in the token #1282
Conversation
a927ff2
to
c45ac32
Compare
c45ac32
to
05895cb
Compare
@rgrunber can you review this and approve ? |
05895cb
to
fc438bc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no issues with the changes, but I don't work with jdt.ls so have no way of verifying this; therefore I'll have to defer to @rgrunber to at least test and report back. I have moved to 4.32 M3 as 4.32 M2 has sailed. Is this something that JDT UI users would also want to utilize in the future?
We tried the out in the following MR in jdt.ls eclipse-jdtls/eclipse.jdt.ls#2835. But I will wait for @rgrunber
Yes I think JDT UI can use this as well if it is a good idea. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me. I'm fine with merging for M3. If it's an improvement, we can write testcases once/if JDT UI adopts it.
fc438bc
to
3a9a473
Compare
What it does
Add a new constructor to pass in the token so that the token will be used when matching the chains. This helps to better control how much chains are produced by using the text that is already typed in an editor as the token. This helps to provide better chains selection without increasing the number of chains to produce for JDT.LS. The existing constructor will preserve the current behavior uneffected.
How to test
This new behavior can be only tested with JDT.LS PR eclipse-jdtls/eclipse.jdt.ls#2835
Author checklist