Consider token to limit the chains that are searched #2835

gayanper · 2023-09-05T18:54:46Z

This draft use a copy of ChainFinder to tryout using token to limit the number of chain produced by the the chain finder. Instead of increasing the chain size which could potentially go into more deeper search, this approach provides the capability to user to filter by the token to find the most relevant chains the user is searching for.

gayanper · 2023-09-05T18:56:05Z

@rgrunber @jdneo @testforstephen @snjeza what do you think about this change ?

rgrunber · 2023-09-05T19:06:05Z

We could increase this, but as mentioned in #2730 (comment), I think we'll be limited by the performance of the chain search. Increasing the maximum chains might not necessarily mean more chains if we're always hitting the timeout, and returning no results. Part of the reason I kept it so small, is I felt there would be a limited number of chains that are useful.

gayanper · 2023-09-06T19:01:19Z

I will have a look at that root cause to see if we can improve the type resolution over there in jdt.

gayanper · 2023-11-13T18:13:03Z

@rgrunber Can you check my new way of tackling the same issue ? if it looks good, I can add the changes to jdt chain finder and use it in JDT LS, while we keep that open for JDT project adapt if there is any contributor for JDT.UI.

rgrunber

This would eliminate EMPTY_LIST. Are you ok with that for now ?

...e.jdt.ls.tests/src/org/eclipse/jdt/ls/core/internal/handlers/CompletionHandlerChainTest.java

org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/contentassist/ChainFinder.java

gayanper · 2023-11-15T19:54:51Z

This would eliminate EMPTY_LIST. Are you ok with that for now ?

What if we make the token match case insensitive and let the completion filter handle the rest ? So if I type empty I should get both.

gayanper · 2023-12-30T18:55:08Z

@rgrunber WDYT about latest changes ? If this looks good, would you prefer adding this changes to jdt.ui or should we keep a copy of ChainFinder in jdt.ls and evolve further here ?

rgrunber · 2024-03-21T18:22:50Z

Could we use ChainFinder directly from jdt.core.manipulation. I'd be fine with merging directly in there if anything extra is needed.

gayanper · 2024-03-24T20:53:38Z

Depends on eclipse-jdt/eclipse.jdt.ui#1282

gayanper · 2024-06-07T18:59:19Z

@rgrunber the PR is ready now

gayanper · 2024-06-22T16:12:38Z

@rgrunber do you think we can merge this as well to master ?

rgrunber · 2024-06-22T17:19:16Z

Yes, I plan to review this. I'm guessing if we merge this, we can also close #2935 (that commit is included here) ? I guess my only complaint there was about using CompletionProposal, but if the reasoning was because it stays closer to existing code (and its coupling with that class) then that's fine.

gayanper · 2024-07-06T18:20:02Z

Yes you got my reasoning right @rgrunber. Let me know if you see any improvements that we should do, otherwise it would be nice to have both of this PRs in master :)

...core/src/org/eclipse/jdt/ls/core/internal/contentassist/ChainCompletionProposalComputer.java

...rc/org/eclipse/jdt/ls/core/internal/contentassist/CompletionProposalReplacementProvider.java

rgrunber · 2024-08-01T19:38:31Z

Also, there appear to be some test failures : https://ci.eclipse.org/ls/job/jdt-ls-pr/5176/ . The ones in CompletionHandlerChainTest seem consistent.

gayanper · 2024-08-03T12:07:53Z

@rgrunber did running unit tests method changed recently for JDT.LS tests ? When trying to run the unit tests I get the following error

Required plug-in 'org.eclipse.pde.junit.runtime' could not be found.

rgrunber · 2024-08-03T17:56:23Z

PDE definitely wouldn't be in the target platform of JDT-LS, so not sure why it would be needed. It should be part of the platform from which you're launching the plugin-in test though. Maybe you could try clearing any JUnit Plugin Test launch configurations ?

gayanper · 2024-08-03T18:22:06Z

@rgrunber I found that adding the following into the MANIFEST and target platform file in test module to resolve the issue.

 org.eclipse.pde.junit.runtime,
 org.eclipse.jdt.junit4.runtime

gayanper · 2024-08-03T18:23:49Z

@rgrunber also I found the reason we have the remove snippet text. Without it the tests are failing with following mismatch in Label assertions of the completions

Expected: streams[i].toList() : List
Actual : streams[${1:i}].toList() : List

gayanper · 2024-08-04T07:19:34Z

@rgrunber also I found the reason we have the remove snippet text. Without it the tests are failing with following mismatch in Label assertions of the completions

Expected: streams[i].toList() : List Actual : streams[${1:i}].toList() : List

Provided a better fix for this

gayanper · 2024-08-04T07:19:54Z

@rgrunber I found that adding the following into the MANIFEST and target platform file in test module to resolve the issue.
 org.eclipse.pde.junit.runtime,
 org.eclipse.jdt.junit4.runtime

This only needed to be added into target platform.

gayanper · 2024-08-04T10:15:00Z

@rgrunber the failing tests right now testCompletion_Lambda seems pass when I try to run it locally, are there some know random failures like this one in CI ?

testforstephen · 2024-08-05T04:32:06Z

@rgrunber did running unit tests method changed recently for JDT.LS tests ? When trying to run the unit tests I get the following error
Required plug-in 'org.eclipse.pde.junit.runtime' could not be found.

If you're using vscode-pde extension to run JUnit plugin test, the latest [email protected] has fixed this issue.

org.eclipse.jdt.ls.target/org.eclipse.jdt.ls.tp.target

gayanper · 2024-08-10T10:03:04Z

@rgrunber did running unit tests method changed recently for JDT.LS tests ? When trying to run the unit tests I get the following error
Required plug-in 'org.eclipse.pde.junit.runtime' could not be found.
If you're using vscode-pde extension to run JUnit plugin test, the latest [email protected] has fixed this issue.

I tried installing, but that gave me some errors on conflicting modules

org.osgi.framework.BundleException: Could not resolve module: org.eclipse.jdt.ls.importer.pde [252]
  Unresolved requirement: Require-Bundle: org.eclipse.pde.launching
    -> Bundle-SymbolicName: org.eclipse.pde.launching; bundle-version="3.13.0.v20240424-1246"; singleton:="true"
       org.eclipse.pde.launching [257]
         Unresolved requirement: Require-Bundle: org.eclipse.pde.core; bundle-version="[3.2.0,4.0.0)"
           -> Bundle-SymbolicName: org.eclipse.pde.core; bundle-version="3.18.100.v20240531-0649"; singleton:="true"
              org.eclipse.pde.core [255]
                Unresolved requirement: Import-Package: org.bndtools.versioncontrol.ignores.manager.api; version="[1.0.0,2.0.0)"
  Unresolved requirement: Require-Bundle: org.eclipse.m2e.pde.target
    -> Bundle-SymbolicName: org.eclipse.m2e.pde.target; bundle-version="2.0.501.20240411-1122"; singleton:="true"
       org.eclipse.m2e.pde.target [253]
         Unresolved requirement: Require-Bundle: org.eclipse.pde.core; bundle-version="3.14.0"
           -> Bundle-SymbolicName: org.eclipse.pde.core; bundle-version="3.18.100.v20240531-0649"; singleton:="true"
  Unresolved requirement: Require-Bundle: org.eclipse.pde.core
    -> Bundle-SymbolicName: org.eclipse.pde.core; bundle-version="3.18.100.v20240531-0649"; singleton:="true"

	at org.eclipse.osgi.container.Module.start(Module.java:493)
	at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel$2.run(ModuleContainer.java:2074)
	at org.eclipse.osgi.internal.framework.EquinoxContainerAdaptor$1$1.execute(EquinoxContainerAdaptor.java:143)
	at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:2065)
	at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:2005)
	at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.doContainerStartLevel(ModuleContainer.java:1968)
	at org.eclipse.osgi.container.SystemModule.startWorker(SystemModule.java:274)
	at org.eclipse.osgi.container.Module.doStart(Module.java:639)
	at org.eclipse.osgi.container.Module.start(Module.java:498)
	at org.eclipse.osgi.container.SystemModule.start(SystemModule.java:198)
	at org.eclipse.osgi.internal.framework.EquinoxBundle.start(EquinoxBundle.java:463)
	at org.eclipse.osgi.internal.framework.EquinoxBundle.start(EquinoxBundle.java:482)
	at org.eclipse.osgi.launch.Equinox.start(Equinox.java:139)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.startup(EclipseStarter.java:367)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:267)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
	at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:668)
	at org.eclipse.equinox.launcher.Main.basicRun(Main.java:605)
	at org.eclipse.equinox.launcher.Main.run(Main.java:1481)
	at org.eclipse.equinox.launcher.Main.main(Main.java:1454)


[Error - 11:57:34 AM] Aug 10, 2024, 11:57:32 AM FrameworkEvent ERROR
org.osgi.framework.BundleException: Could not resolve module: org.eclipse.m2e.pde.target [253]
  Unresolved requirement: Require-Bundle: org.eclipse.pde.core; bundle-version="3.14.0"
    -> Bundle-SymbolicName: org.eclipse.pde.core; bundle-version="3.18.100.v20240531-0649"; singleton:="true"
       org.eclipse.pde.core [255]
         Unresolved requirement: Import-Package: org.bndtools.versioncontrol.ignores.manager.api; version="[1.0.0,2.0.0)"

	at org.eclipse.osgi.container.Module.start(Module.java:493)
	at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel$2.run(ModuleContainer.java:2074)
	at org.eclipse.osgi.internal.framework.EquinoxContainerAdaptor$1$1.execute(EquinoxContainerAdaptor.java:143)
	at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:2065)
	at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:2005)
	at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.doContainerStartLevel(ModuleContainer.java:1968)
	at org.eclipse.osgi.container.SystemModule.startWorker(SystemModule.java:274)
	at org.eclipse.osgi.container.Module.doStart(Module.java:639)
	at org.eclipse.osgi.container.Module.start(Module.java:498)
	at org.eclipse.osgi.container.SystemModule.start(SystemModule.java:198)
	at org.eclipse.osgi.internal.framework.EquinoxBundle.start(EquinoxBundle.java:463)
	at org.eclipse.osgi.internal.framework.EquinoxBundle.start(EquinoxBundle.java:482)
	at org.eclipse.osgi.launch.Equinox.start(Equinox.java:139)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.startup(EclipseStarter.java:367)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:267)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
	at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:668)
	at org.eclipse.equinox.launcher.Main.basicRun(Main.java:605)
	at org.eclipse.equinox.launcher.Main.run(Main.java:1481)
	at org.eclipse.equinox.launcher.Main.main(Main.java:1454)

[Error - 11:57:34 AM] Aug 10, 2024, 11:57:32 AM FrameworkEvent ERROR
org.osgi.framework.BundleException: Could not resolve module: org.eclipse.pde.core [255]
  Unresolved requirement: Import-Package: org.bndtools.versioncontrol.ignores.manager.api; version="[1.0.0,2.0.0)"

	at org.eclipse.osgi.container.Module.start(Module.java:493)
	at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel$2.run(ModuleContainer.java:2074)
	at org.eclipse.osgi.internal.framework.EquinoxContainerAdaptor$1$1.execute(EquinoxContainerAdaptor.java:143)
	at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:2065)
	at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:2005)
	at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.doContainerStartLevel(ModuleContainer.java:1968)
	at org.eclipse.osgi.container.SystemModule.startWorker(SystemModule.java:274)
	at org.eclipse.osgi.container.Module.doStart(Module.java:639)
	at org.eclipse.osgi.container.Module.start(Module.java:498)
	at org.eclipse.osgi.container.SystemModule.start(SystemModule.java:198)
	at org.eclipse.osgi.internal.framework.EquinoxBundle.start(EquinoxBundle.java:463)
	at org.eclipse.osgi.internal.framework.EquinoxBundle.start(EquinoxBundle.java:482)
	at org.eclipse.osgi.launch.Equinox.start(Equinox.java:139)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.startup(EclipseStarter.java:367)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:267)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
	at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:668)
	at org.eclipse.equinox.launcher.Main.basicRun(Main.java:605)
	at org.eclipse.equinox.launcher.Main.run(Main.java:1481)
	at org.eclipse.equinox.launcher.Main.main(Main.java:1454)

[Error - 11:57:34 AM] Aug 10, 2024, 11:57:32 AM FrameworkEvent ERROR
org.osgi.framework.BundleException: Could not resolve module: org.eclipse.pde.launching [257]
  Unresolved requirement: Require-Bundle: org.eclipse.pde.core; bundle-version="[3.2.0,4.0.0)"
    -> Bundle-SymbolicName: org.eclipse.pde.core; bundle-version="3.18.100.v20240531-0649"; singleton:="true"
       org.eclipse.pde.core [255]
         Unresolved requirement: Import-Package: org.bndtools.versioncontrol.ignores.manager.api; version="[1.0.0,2.0.0)"

	at org.eclipse.osgi.container.Module.start(Module.java:493)
	at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel$2.run(ModuleContainer.java:2074)
	at org.eclipse.osgi.internal.framework.EquinoxContainerAdaptor$1$1.execute(EquinoxContainerAdaptor.java:143)
	at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:2065)
	at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:2005)
	at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.doContainerStartLevel(ModuleContainer.java:1968)
	at org.eclipse.osgi.container.SystemModule.startWorker(SystemModule.java:274)
	at org.eclipse.osgi.container.Module.doStart(Module.java:639)
	at org.eclipse.osgi.container.Module.start(Module.java:498)
	at org.eclipse.osgi.container.SystemModule.start(SystemModule.java:198)
	at org.eclipse.osgi.internal.framework.EquinoxBundle.start(EquinoxBundle.java:463)
	at org.eclipse.osgi.internal.framework.EquinoxBundle.start(EquinoxBundle.java:482)
	at org.eclipse.osgi.launch.Equinox.start(Equinox.java:139)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.startup(EclipseStarter.java:367)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:267)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
	at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:668)
	at org.eclipse.equinox.launcher.Main.basicRun(Main.java:605)
	at org.eclipse.equinox.launcher.Main.run(Main.java:1481)
	at org.eclipse.equinox.launcher.Main.main(Main.java:1454)

[Error - 11:57:34 AM] Aug 10, 2024, 11:57:34 AM Cannot refresh bundle org.eclipse.jdt.ls.core because its dependency closure includes the org.eclipse.jdt.ls.core bundle.
[Error - 11:57:34 AM] Aug 10, 2024, 11:57:34 AM Failed to load extension bundles 
Load bundle list
org.eclipse.core.runtime.CoreException: Load bundle list
	at org.eclipse.jdt.ls.core.internal.handlers.BundleUtils.loadBundles(BundleUtils.java:173)
	at org.eclipse.jdt.ls.core.internal.handlers.InitHandler.handleInitializationOptions(InitHandler.java:113)
	at org.eclipse.jdt.ls.core.internal.handlers.BaseInitHandler.initialize(BaseInitHandler.java:64)
	at org.eclipse.jdt.ls.core.internal.handlers.JDTLanguageServer.initialize(JDTLanguageServer.java:283)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
	at org.eclipse.lsp4j.jsonrpc.services.GenericEndpoint.lambda$recursiveFindRpcMethods$0(GenericEndpoint.java:65)
	at org.eclipse.lsp4j.jsonrpc.services.GenericEndpoint.request(GenericEndpoint.java:128)
	at org.eclipse.lsp4j.jsonrpc.RemoteEndpoint.handleRequest(RemoteEndpoint.java:271)
	at org.eclipse.lsp4j.jsonrpc.RemoteEndpoint.consume(RemoteEndpoint.java:201)
	at org.eclipse.jdt.ls.core.internal.ParentProcessWatcher.lambda$1(ParentProcessWatcher.java:144)
	at org.eclipse.lsp4j.jsonrpc.json.StreamMessageProducer.handleMessage(StreamMessageProducer.java:185)
	at org.eclipse.lsp4j.jsonrpc.json.StreamMessageProducer.listen(StreamMessageProducer.java:97)
	at org.eclipse.lsp4j.jsonrpc.json.ConcurrentMessageProcessor.run(ConcurrentMessageProcessor.java:114)
	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
	at java.base/java.lang.Thread.run(Thread.java:833)
Contains: Install bundle failure /Users/gayanperera/.vscode/extensions/vscjava.vscode-java-test-0.42.2024080609/server/org.apiguardian.api_1.1.2.jar
org.osgi.framework.BundleException: A bundle is already installed with the name "org.apiguardian.api" and version "1.1.2"
	at org.eclipse.osgi.container.ModuleContainer.install(ModuleContainer.java:451)
	at org.eclipse.osgi.storage.Storage.install(Storage.java:754)
	at org.eclipse.osgi.internal.framework.BundleContextImpl.installBundle(BundleContextImpl.java:181)
	at org.eclipse.osgi.internal.framework.BundleContextImpl.installBundle(BundleContextImpl.java:174)
	at org.eclipse.jdt.ls.core.internal.handlers.BundleUtils.installBundle(BundleUtils.java:189)
	at org.eclipse.jdt.ls.core.internal.handlers.BundleUtils.loadBundles(BundleUtils.java:159)
	at org.eclipse.jdt.ls.core.internal.handlers.InitHandler.handleInitializationOptions(InitHandler.java:113)
	at org.eclipse.jdt.ls.core.internal.handlers.BaseInitHandler.initialize(BaseInitHandler.java:64)
	at org.eclipse.jdt.ls.core.internal.handlers.JDTLanguageServer.initialize(JDTLanguageServer.java:283)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
	at org.eclipse.lsp4j.jsonrpc.services.GenericEndpoint.lambda$recursiveFindRpcMethods$0(GenericEndpoint.java:65)
	at org.eclipse.lsp4j.jsonrpc.services.GenericEndpoint.request(GenericEndpoint.java:128)
	at org.eclipse.lsp4j.jsonrpc.RemoteEndpoint.handleRequest(RemoteEndpoint.java:271)
	at org.eclipse.lsp4j.jsonrpc.RemoteEndpoint.consume(RemoteEndpoint.java:201)
	at org.eclipse.jdt.ls.core.internal.ParentProcessWatcher.lambda$1(ParentProcessWatcher.java:144)
	at org.eclipse.lsp4j.jsonrpc.json.StreamMessageProducer.handleMessage(StreamMessageProducer.java:185)
	at org.eclipse.lsp4j.jsonrpc.json.StreamMessageProducer.listen(StreamMessageProducer.java:97)
	at org.eclipse.lsp4j.jsonrpc.json.ConcurrentMessageProcessor.run(ConcurrentMessageProcessor.java:114)
	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
	at java.base/java.lang.Thread.run(Thread.java:833)

testforstephen · 2024-08-10T11:19:17Z

-> Bundle-SymbolicName: org.eclipse.pde.launching; bundle-version="3.13.0.v20240424-1246"; singleton:="true"

Where did you get the vscode-pde extension? Apparently the pde version you're using does not match what's included in the marketplace version.

See https://github.com/testforstephen/vscode-pde/blob/795f86673ba29f50f7c1f3e09c63d9d155577bfc/package.json#L62, the dependency version it uses is org.eclipse.pde.launching_3.12.0.v20240214-2143.jar.

gayanper · 2024-08-11T13:38:23Z

-> Bundle-SymbolicName: org.eclipse.pde.launching; bundle-version="3.13.0.v20240424-1246"; singleton:="true"
Where did you get the vscode-pde extension? Apparently the pde version you're using does not match what's included in the marketplace version.

See https://github.com/testforstephen/vscode-pde/blob/795f86673ba29f50f7c1f3e09c63d9d155577bfc/package.json#L62, the dependency version it uses is org.eclipse.pde.launching_3.12.0.v20240214-2143.jar.

Strange, i updated it from marketplace. I will try to clear any cached extension files and try installing from marketplace again.

rgrunber

Just noticed you reverted the target changes here. Ok, this was exactly what I was waiting for. We're aiming for a release by Thursday, but once that's done, I'll just merge this in.

gayanper · 2024-08-26T16:59:06Z

Sure i can make it ready by resolving the conflict as well.

- simplify the code by reusing CompletionProposalRequestor to create items - add support for javadoc for chain completions

…nt proposals are shown.

…letions

gayanper · 2024-08-30T19:19:28Z

@rgrunber resolved the conflicts

gayanper marked this pull request as draft September 5, 2023 18:55

gayanper force-pushed the increase-context-chain-size branch from ef32135 to 79642ad Compare November 13, 2023 18:09

gayanper changed the title ~~Increase the context entrypoint chain size~~ Consider token to limit the chains that are searched Nov 13, 2023

rgrunber reviewed Nov 15, 2023

View reviewed changes

...e.jdt.ls.tests/src/org/eclipse/jdt/ls/core/internal/handlers/CompletionHandlerChainTest.java Outdated Show resolved Hide resolved

org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/contentassist/ChainFinder.java Outdated Show resolved Hide resolved

gayanper force-pushed the increase-context-chain-size branch 2 times, most recently from c214002 to a0d6d1e Compare March 21, 2024 17:42

gayanper mentioned this pull request Mar 24, 2024

Add support to filter chain by passing the in the token eclipse-jdt/eclipse.jdt.ui#1282

Merged

3 tasks

gayanper force-pushed the increase-context-chain-size branch from a0d6d1e to db8b7c0 Compare June 7, 2024 18:43

gayanper marked this pull request as ready for review June 7, 2024 18:43

gayanper force-pushed the increase-context-chain-size branch 2 times, most recently from 15b0a01 to a074ee8 Compare July 15, 2024 17:48

rgrunber added the performance label Jul 19, 2024

rgrunber reviewed Jul 31, 2024

View reviewed changes

...core/src/org/eclipse/jdt/ls/core/internal/contentassist/ChainCompletionProposalComputer.java Outdated Show resolved Hide resolved

rgrunber reviewed Jul 31, 2024

View reviewed changes

...core/src/org/eclipse/jdt/ls/core/internal/contentassist/ChainCompletionProposalComputer.java Outdated Show resolved Hide resolved

rgrunber reviewed Jul 31, 2024

View reviewed changes

...rc/org/eclipse/jdt/ls/core/internal/contentassist/CompletionProposalReplacementProvider.java Show resolved Hide resolved

gayanper force-pushed the increase-context-chain-size branch from f3466a4 to 4895d43 Compare August 3, 2024 12:13

rgrunber added this to the End August 2024 milestone Aug 6, 2024

rgrunber reviewed Aug 6, 2024

View reviewed changes

org.eclipse.jdt.ls.target/org.eclipse.jdt.ls.tp.target Show resolved Hide resolved

gayanper force-pushed the increase-context-chain-size branch from 6e0c134 to 447a11d Compare August 10, 2024 10:00

rgrunber approved these changes Aug 26, 2024

View reviewed changes

rgrunber modified the milestones: End August 2024, End September 2024 Aug 27, 2024

gayanper added 9 commits August 30, 2024 21:16

Improve chain completions

a1198eb

- simplify the code by reusing CompletionProposalRequestor to create items - add support for javadoc for chain completions

Improve chain completion proposals consider token so that more releva…

145c616

…nt proposals are shown.

add subword match on edge and start

5bb6551

use the new chainfinder constructor from jdt.ui

cc3ba13

review feedback changes

3c633ed

review feedback changes

ca3cbba

improve text computation and properly wait and timeout for chain comp…

cb8ea73

…letions

add missing required modules for text execution in vscode

ab27307

revert target changes

bf27d6a

gayanper force-pushed the increase-context-chain-size branch from 447a11d to bf27d6a Compare August 30, 2024 19:18

rgrunber merged commit 0949cc2 into eclipse-jdtls:master Sep 3, 2024
6 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Consider token to limit the chains that are searched #2835

Consider token to limit the chains that are searched #2835

gayanper commented Sep 5, 2023 •

edited

Loading

gayanper commented Sep 5, 2023

rgrunber commented Sep 5, 2023

gayanper commented Sep 6, 2023

gayanper commented Nov 13, 2023

rgrunber left a comment

gayanper commented Nov 15, 2023

gayanper commented Dec 30, 2023

rgrunber commented Mar 21, 2024

gayanper commented Mar 24, 2024

gayanper commented Jun 7, 2024

gayanper commented Jun 22, 2024

rgrunber commented Jun 22, 2024

gayanper commented Jul 6, 2024

rgrunber commented Aug 1, 2024

gayanper commented Aug 3, 2024

rgrunber commented Aug 3, 2024

gayanper commented Aug 3, 2024

gayanper commented Aug 3, 2024

gayanper commented Aug 4, 2024

gayanper commented Aug 4, 2024

gayanper commented Aug 4, 2024

testforstephen commented Aug 5, 2024

gayanper commented Aug 10, 2024

testforstephen commented Aug 10, 2024

gayanper commented Aug 11, 2024

rgrunber left a comment

gayanper commented Aug 26, 2024

gayanper commented Aug 30, 2024

Consider token to limit the chains that are searched #2835

Consider token to limit the chains that are searched #2835

Conversation

gayanper commented Sep 5, 2023 • edited Loading

gayanper commented Sep 5, 2023

rgrunber commented Sep 5, 2023

gayanper commented Sep 6, 2023

gayanper commented Nov 13, 2023

rgrunber left a comment

Choose a reason for hiding this comment

gayanper commented Nov 15, 2023

gayanper commented Dec 30, 2023

rgrunber commented Mar 21, 2024

gayanper commented Mar 24, 2024

gayanper commented Jun 7, 2024

gayanper commented Jun 22, 2024

rgrunber commented Jun 22, 2024

gayanper commented Jul 6, 2024

rgrunber commented Aug 1, 2024

gayanper commented Aug 3, 2024

rgrunber commented Aug 3, 2024

gayanper commented Aug 3, 2024

gayanper commented Aug 3, 2024

gayanper commented Aug 4, 2024

gayanper commented Aug 4, 2024

gayanper commented Aug 4, 2024

testforstephen commented Aug 5, 2024

gayanper commented Aug 10, 2024

testforstephen commented Aug 10, 2024

gayanper commented Aug 11, 2024

rgrunber left a comment

Choose a reason for hiding this comment

gayanper commented Aug 26, 2024

gayanper commented Aug 30, 2024

gayanper commented Sep 5, 2023 •

edited

Loading