Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github-actions: refactor docker #3626

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

v1v
Copy link
Member

@v1v v1v commented May 9, 2024

What does this PR do?

Use https://docs.docker.com/build/building/multi-stage/ to generate the Docker image. This will help using Docker natively to fetch the artifacts with some build-args (whether using the standalone files or fetching from Sonatype given the release version). This will make the Docker image agnostic to the host.

In addition, it removes the complexity of using shell scripts. and use native GitHub action support with tag and label detection.

Generate docker images for the snapshots using the docker tag name test-latest.

Finally, this will help us provide some provenance for the docker images, which was not done as docker build/push was in shell scripts.

Checklist

  • This is an enhancement of existing features, or a new feature in existing plugins
    • I have updated CHANGELOG.asciidoc
    • I have added tests that prove my fix is effective or that my feature works
    • Added an API method or config option? Document in which version this will be introduced
    • I have made corresponding changes to the documentation
  • This is a bugfix
  • This is a new plugin
    • I have updated CHANGELOG.asciidoc
    • My code follows the style guidelines of this project
    • I have made corresponding changes to the documentation
    • I have added tests that prove my fix is effective or that my feature works
    • New and existing unit tests pass locally with my changes
    • I have updated supported-technologies.asciidoc
    • Added an API method or config option? Document in which version this will be introduced
    • Added an instrumentation plugin? Describe how you made sure that old, non-supported versions are not instrumented by accident.
  • This is something else

This will help with using docker to fetch the artifacts with some build-args

This will make the docker image be agnostic to the host

In addition, it removes the complexity for using shell scripts

and use antive github action support
@v1v v1v self-assigned this May 9, 2024
@SylvainJuge
Copy link
Member

The #3652 PR is also likely to introduce a few other conflicts, but the underlying issue might be implicitly fixed by only downloading and not as a fallback of the local build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

2 participants