Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customize CSS #178

Merged
merged 3 commits into from
Jul 17, 2024
Merged

Customize CSS #178

merged 3 commits into from
Jul 17, 2024

Conversation

eagleoflqj
Copy link
Member

No description provided.

@eagleoflqj eagleoflqj requested a review from ksqsf July 13, 2024 20:32
Copy link
Member

@ksqsf ksqsf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me.

A small problem: the current way to unload user CSS seems not intuitive. Cancel should do nothing, and there should be a more prominent way to unload it, e.g. add a button like (x) next to it. This is not merge-blocking, as it can be deferred to another PR.

@ksqsf
Copy link
Member

ksqsf commented Jul 17, 2024

did what i proposed: image

@ksqsf ksqsf merged commit c81e529 into master Jul 17, 2024
1 check passed
@ksqsf ksqsf deleted the customize-css branch July 17, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants