-
Notifications
You must be signed in to change notification settings - Fork 977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Updating OnDemandFeatureView to add Entities and batch_source #4530
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Francisco Javier Arceo <[email protected]>
Signed-off-by: Francisco Javier Arceo <[email protected]>
…otobuf Signed-off-by: Francisco Javier Arceo <[email protected]>
Signed-off-by: Francisco Javier Arceo <[email protected]>
Signed-off-by: Francisco Javier Arceo <[email protected]>
name_alias=None, | ||
features=base_feature_view.features, | ||
desired_features=[], | ||
timestamp_field=base_feature_view.batch_source.created_timestamp_column # type:ignore[attr-defined] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is admittedly a hack and I don't like it but this should be refactored in 1.0.0
My overall learning from this is that FeatureViews should be really derived from the same object with the same class parameters and make them optionally instantiated.
This should be described more thoroughly for 1.0.0
Signed-off-by: Francisco Javier Arceo <[email protected]>
Signed-off-by: Francisco Javier Arceo <[email protected]>
Signed-off-by: Francisco Javier Arceo <[email protected]>
…ing to put a workaround Signed-off-by: Francisco Javier Arceo <[email protected]>
Signed-off-by: Francisco Javier Arceo <[email protected]>
Signed-off-by: Francisco Javier Arceo <[email protected]>
Signed-off-by: Francisco Javier Arceo <[email protected]>
Signed-off-by: Francisco Javier Arceo <[email protected]>
What this PR does / why we need it:
This PR
FeatureViewProjection
to include the underlying data sources forOnDemandFeatureView
. This allows for much richer lineage when constructing metadata about anOnDemandFeatureView
s and its data sources.OnDemandFeatureView
to optionally supportentities
, which will be required to write anOnDemandFeatureView
to the online storeBaseFeatureView
to include sources to optionally includebath_source
write_to_online_store
boolean toOnDemandFeatureView
(note not used)Which issue(s) this PR fixes:
Misc