-
Notifications
You must be signed in to change notification settings - Fork 977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Updating OnDemandFeatureView to add Entities and batch_source #4530
Draft
franciscojavierarceo
wants to merge
13
commits into
master
Choose a base branch
from
fv-projections
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+391
−72
Draft
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
c961c8a
feat: Updating protos for Projections to include more info
franciscojavierarceo f8fdaa2
adding unit test
franciscojavierarceo 2d037cb
adding type checking where batch source is already serialized into pr…
franciscojavierarceo 3d9da06
almost got everything working and type validation behaving
franciscojavierarceo 3fe06dd
cleaned up and have tests behaving
franciscojavierarceo ed97620
removed comment
franciscojavierarceo 8cb2471
updated FeatureViewProjection batch_source serialization
franciscojavierarceo 6a78b15
trying to debug a test
franciscojavierarceo f28a713
handling snowflake issue, cant confirm why it is happening so just go…
franciscojavierarceo 6f801ea
linter
franciscojavierarceo de4d6ce
trying to handle it correctly
franciscojavierarceo 082415f
handling the else case for from_feature_view_definition
franciscojavierarceo f50923f
adding print
franciscojavierarceo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is admittedly a hack and I don't like it but this should be refactored in 1.0.0
My overall learning from this is that FeatureViews should be really derived from the same object with the same class parameters and make them optionally instantiated.
This should be described more thoroughly for 1.0.0