fix CI #1014
Merged
fix CI #1014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1014 +/- ##
=======================================
Coverage 98.04% 98.04%
=======================================
Files 23 23
Lines 2409 2409
=======================================
Hits 2362 2362
Misses 47 47 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI was using a shell (see also) such that only the final exit code generated by a step could cause a failure (i.e., if a line in the middle of a step's
rundefinition exited with a non-zero, the step would "succeed" anyway. This behavior only started a few days ago, and I just noticed it. Prior to that, tests were failing appropriately up until ~5 days ago. In the meantime, tests were silently failing while appearing to be passing.