Add labels to deployment, statefulset, service accounts and volumeClaimTemplates #680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Iristyle
force-pushed
the
add-deployment-statefulset-serviceaccount-labels
branch
from
b7adbc2
to
92cd8bf
Compare
Iristyle
changed the title
|
For some reason only the CLA is running and not the normal CircleCI checks... ran all unit tests locally successfully |
tvoran
added
enhancement
|
|
|
Any update on this? I am looking for this addition as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supersedes #478 by adding missing tests
Will add another commit with PVC labelsAdded additional commit with the PVC labels as well... this is helpful when using automation against all resources with a specific label.