Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL] Defer buffer release when no host memory to be updated #6837
[SYCL] Defer buffer release when no host memory to be updated #6837
Changes from 20 commits
0601210
aff3be6
1195b59
8d05802
b54b8e4
965a015
27ccbff
9540fe0
c00c7cb
661dace
6615db3
8174dc3
d55405e
bb2c4fb
5db9e85
53a1892
4b0a3fa
8daea20
c855f13
8dbcd1c
0f61c64
ddf215b
23bea82
aa41d76
e296d03
179c472
2076c7c
e911d0a
81c2b09
edcfcfc
b5e85de
a5980a0
ac06f1b
09b8359
1e75448
484b1cf
1061322
d4537a3
342ff91
fdab0e7
0872d7c
3a25f1e
28f008d
92b5e15
6247f8a
4133862
79b2125
868973c
1bc8e57
6e0943b
1c62d08
30dfaf2
60e3011
6964876
3d5315e
467a9ea
0b9032a
9d570ce
c6d5dc7
a0b37ef
619ee4e
3187f0a
dbe88e2
06e2608
71e9048
a89e577
ceea7f8
1f201a9
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems to be unsafe to release DefaultHostQueue here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets first get results if the solution helps
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably, it makes sense to use
std::vector
here as well.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed in 28f008d