Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prep for v1.19.0 #2232

Merged
merged 8 commits into from
Aug 16, 2023
Merged

Prep for v1.19.0 #2232

merged 8 commits into from
Aug 16, 2023

Conversation

odow
Copy link
Member

@odow odow commented Jun 28, 2023 •
edited
Loading

Basic

  • version field of Project.toml has been updated
    - If a breaking change, increment the MAJOR field and reset others to 0
    - If adding new features, increment the MINOR field and reset PATCH to 0
    - If adding bug fixes or documentation changes, increment the PATCH field

Documentation

  • Add a new entry to docs/src/changelog.md, following existing style

Tests

@odow
Copy link
Member Author

odow commented Jun 28, 2023

This release is mostly so that we can release AmplNLWriter with ScalarNonlinearFunction support.

@odow odow requested a review from blegat June 29, 2023 09:35
@odow
Copy link
Member Author

odow commented Jun 29, 2023 •
edited
Loading

Wait for

odow
odow commented Aug 2, 2023
View reviewed changes
docs/src/changelog.md Outdated Show resolved Hide resolved
odow
odow commented Aug 2, 2023
View reviewed changes
docs/src/changelog.md Outdated Show resolved Hide resolved
odow
odow commented Aug 2, 2023
View reviewed changes
docs/src/changelog.md Outdated Show resolved Hide resolved
odow
odow commented Aug 7, 2023
View reviewed changes
docs/src/changelog.md Outdated Show resolved Hide resolved
@blegat
Copy link
Member

blegat commented Aug 8, 2023

Maybe we could add #2237 as well, the PR is now ready

@odow odow mentioned this pull request Aug 8, 2023
Closed
@odow
Copy link
Member Author

odow commented Aug 14, 2023 •
edited
Loading

@odow
Copy link
Member Author

odow commented Aug 15, 2023 •
edited
Loading

@odow
Copy link
Member Author

odow commented Aug 15, 2023

@blegat okay to merge?

@blegat blegat merged commit 8bb8ea9 into master Aug 16, 2023
56 checks passed
@blegat blegat deleted the od/v1.19 branch August 16, 2023 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blegat blegat blegat approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@odow @blegat