Verifier tests #23
Merged
Verifier tests #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added more documentation for cargo docs.
Added documentation and removed the use of `PhatomData` here as it seemed unnecessary.
fixed most borrow checker errors lifetime annotations, verifier test compiles cleaned up commented code update unimplemented message making it work on composer, assuming you squash this
JDLBeckman
force-pushed
the
verifier-tests
branch
from
9b3029d
to
185514a
Compare
|
beautiful wonderful gorgeous thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Got the verifier tests to compile (not pass, but as I understood it that was out of scope). I tried to mess with anything outside of the verifier
test.rsas little as possible.A few places where I was guessing and suspect I might have made the wrong changes in other parts of the code:
keyinProverPermutationWidget/TransitionWidgetinto anRc<RefCell<...>>instead of justRc<...>. I think that this needs to be this way because the key is shared withProver, which does need to modify it.get_monomial_pointstake& selfinstead of&mut self. The original Barretenberg declaration is non-const, but the implementations all could have beenconst, and my intuition is that this function is just supposed to act like a getter and never actually modify the reference string, but maybe you have something planned for this Pippenger guy that contradicts that?