LMB-339 | Set effectiefAt when publication status is switched to effectief #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cation status is set to effectief
JonasVanHoof
changed the base branch from
master
to
karel/lmb-521-send-notifications
JonasVanHoof
commented
Sep 19, 2024
Comment on lines
+61
to
+63
| if (publicationStatus?.uri === MANDATARIS_DRAFT_PUBLICATION_STATE) { | ||
| this.args.mandataris.effectiefAt = null; | ||
| } |
There was a problem hiding this comment.
This is done so when switching to bekrachtigd status this value is not removed, onlt when setting back to draft status.
This was referenced Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Set effectiefAt when publication status is switched to effectief
How to test
Switch the publication status to effectief throught the publication status selector
Links to other PR's